Re: [PATCH 2/3 v2] proc: Export statistics for softirq to /proc

kobayashi.kk
2009-01-10T18:22:35Z

2009/1/9 Andrew Morton <akpm@linux-foundation.org>:
> On Wed, 26 Nov 2008 19:10:28 +0900 (JST)
> KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
>
>> nit
>>
>> > @@ -49,6 +50,10 @@ static int show_stat(struct seq_file *p, void *v)
>> > sum += kstat_irqs_cpu(j, i);
>> >
>> > sum += arch_irq_stat_cpu(i);
>> > +
>> > + for (j = 0; j < NR_SOFTIRQS; j++)
>> > + sum_softirq += kstat_softirqs_cpu(j, i);
>> > +
>> > }
>>
>> You can calcurate per_irq_sum here.
>> Typically, # of possible cpu are very big.
>>
>> So, I don't like unnecessary twrice looping.
>
> I was about to send these patches to Linus, but it seems that this
> optmisation hasn't been addressed?

Thanks for your notice, Andrew.
Of course, thanks for your advice, Kosaki-san.
I didn't check carefully about this point...

Now I am on a business trip.
So, I'll post the fix next week.

// Keika Kobayashi