From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: linux-kernel@vger.kernel.org
Cc: felipe.balbi@nokia.com, linux-usb@vger.kernel.org
Subject: Re: [patch v2.6.28-rc6-28-g5bcdadf 6/7] usb: musb: use list_is_last
Date: Mon, 24 Nov 2008 18:02:05 +0300 [thread overview]
Message-ID: <492AC1ED.30104@ru.mvista.com> (raw)
In-Reply-To: <20081124145734.GD7476@gandalf.research.nokia.com>
Felipe Balbi wrote:
>>>diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c
>>>index d6a802c..b6aea0b 100644
>>>--- a/drivers/usb/musb/musb_gadget.c
>>>+++ b/drivers/usb/musb/musb_gadget.c
>>>@@ -1159,7 +1159,7 @@ static int musb_gadget_queue(struct usb_ep *ep, struct usb_request *req,
>>> list_add_tail(&(request->request.list), &(musb_ep->req_list));
>>> /* it this is the head of the queue, start i/o ... */
>>>- if (!musb_ep->busy && &request->request.list == musb_ep->req_list.next)
>>>+ if (!musb_ep->busy && list_is_last(&request->request.list, &musb_ep->req_list))
>>
>> This is not the same -- the replaced comparison checked if the request is
>>first in queue, not last. Look at the definition of that function:
> Good catch. Greg, please drop this patch.
BTW, it's strange that there's list_is_last() but no list_is_first()...
WBR, Sergei
parent reply other threads:[~2008-11-24 15:02 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20081124145734.GD7476@gandalf.research.nokia.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492AC1ED.30104@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=felipe.balbi@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox