From: Randy Dunlap <randy.dunlap@oracle.com>
To: Pavel Machek <pavel@suse.cz>
Cc: penberg@cs.helsinki.fi,
kernel list <linux-kernel@vger.kernel.org>,
Greg KH <greg@kroah.com>
Subject: Re: w35und: fix Kconfig
Date: Mon, 24 Nov 2008 08:31:42 -0800 [thread overview]
Message-ID: <492AD6EE.20609@oracle.com> (raw)
In-Reply-To: <20081124091829.GA30292@elf.ucw.cz>
Pavel Machek wrote:
> 4KSTACK dependency was needed when driver carried its own softmac
> layer. That layer is gone, and functions have reasonably small stack
> footprint -> dependency can be removed.
>
> Add better description of hardware this driver is targetted at.
>
> Signed-off-by: Pavel Machek <pavel@suse.cz>
>
> --- gregkh-ofic/drivers/staging/winbond/Kconfig 2008-11-19 11:39:38.000000000 +0100
> +++ gregkh/drivers/staging/winbond/Kconfig 2008-11-19 12:26:57.000000000 +0100
> @@ -1,7 +1,11 @@
> config W35UND
> - tristate "Winbond driver"
> - depends on MAC80211 && WLAN_80211 && USB && EXPERIMENTAL && !4KSTACKS
> + tristate "IS89C35 WLAN USB driver"
> + depends on MAC80211 && WLAN_80211 && USB && EXPERIMENTAL
> default n
> ---help---
> - This is highly experimental driver for winbond wifi card on some Kohjinsha notebooks
> - Check http://code.google.com/p/winbondport/ for new version
> + This is highly experimental driver for Winbond WIFI card.
> +
> + HW is present in some Kohjinsha subnotebooks, and in some
Please spell out "Hardware".
And check for whitespace at ends of lines.
> + stand-alone USB modules. Chipset name seems to be w89c35d.
> +
> + Check http://code.google.com/p/winbondport/ for new version.
--
~Randy
next prev parent reply other threads:[~2008-11-24 16:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 9:18 w35und: fix Kconfig Pavel Machek
2008-11-24 9:25 ` Pekka Enberg
2008-11-24 16:31 ` Randy Dunlap [this message]
2008-11-26 16:15 ` Pavel Machek
2008-11-26 17:34 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492AD6EE.20609@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox