w35und: fix Kconfig

w35und: fix Kconfig

[Pavel Machek]

4KSTACK dependency was needed when driver carried its own softmac
layer. That layer is gone, and functions have reasonably small stack
footprint -> dependency can be removed.

Add better description of hardware this driver is targetted at.

Signed-off-by: Pavel Machek <pavel@suse.cz>

--- gregkh-ofic/drivers/staging/winbond/Kconfig	2008-11-19 11:39:38.000000000 +0100
+++ gregkh/drivers/staging/winbond/Kconfig	2008-11-19 12:26:57.000000000 +0100
@@ -1,7 +1,11 @@
 config W35UND
-	tristate "Winbond driver"
-	depends on MAC80211 && WLAN_80211 && USB && EXPERIMENTAL && !4KSTACKS
+	tristate "IS89C35 WLAN USB driver"
+	depends on MAC80211 && WLAN_80211 && USB && EXPERIMENTAL
 	default n
 	---help---
-	  This is highly experimental driver for winbond wifi card on some Kohjinsha notebooks
-	  Check http://code.google.com/p/winbondport/ for new version
+	  This is highly experimental driver for Winbond WIFI card.
+
+	  HW is present in some Kohjinsha subnotebooks, and in some 
+	  stand-alone USB modules. Chipset name seems to be w89c35d.
+
+	  Check http://code.google.com/p/winbondport/ for new version.

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: w35und: fix Kconfig

[Pekka Enberg]

On Mon, 2008-11-24 at 10:18 +0100, Pavel Machek wrote:
> 4KSTACK dependency was needed when driver carried its own softmac
> layer. That layer is gone, and functions have reasonably small stack
> footprint -> dependency can be removed.
> 
> Add better description of hardware this driver is targetted at.
> 
> Signed-off-by: Pavel Machek <pavel@suse.cz>

While I don't have the hardware to test this, I haven't seen anything in
the driver code either that abuses the kernel stack too badly.

Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>

> 
> --- gregkh-ofic/drivers/staging/winbond/Kconfig	2008-11-19 11:39:38.000000000 +0100
> +++ gregkh/drivers/staging/winbond/Kconfig	2008-11-19 12:26:57.000000000 +0100
> @@ -1,7 +1,11 @@
>  config W35UND
> -	tristate "Winbond driver"
> -	depends on MAC80211 && WLAN_80211 && USB && EXPERIMENTAL && !4KSTACKS
> +	tristate "IS89C35 WLAN USB driver"
> +	depends on MAC80211 && WLAN_80211 && USB && EXPERIMENTAL
>  	default n
>  	---help---
> -	  This is highly experimental driver for winbond wifi card on some Kohjinsha notebooks
> -	  Check http://code.google.com/p/winbondport/ for new version
> +	  This is highly experimental driver for Winbond WIFI card.
> +
> +	  HW is present in some Kohjinsha subnotebooks, and in some 
> +	  stand-alone USB modules. Chipset name seems to be w89c35d.
> +
> +	  Check http://code.google.com/p/winbondport/ for new version.
> 

Re: w35und: fix Kconfig

[Randy Dunlap]

Pavel Machek wrote:
> 4KSTACK dependency was needed when driver carried its own softmac
> layer. That layer is gone, and functions have reasonably small stack
> footprint -> dependency can be removed.
> 
> Add better description of hardware this driver is targetted at.
> 
> Signed-off-by: Pavel Machek <pavel@suse.cz>
> 
> --- gregkh-ofic/drivers/staging/winbond/Kconfig	2008-11-19 11:39:38.000000000 +0100
> +++ gregkh/drivers/staging/winbond/Kconfig	2008-11-19 12:26:57.000000000 +0100
> @@ -1,7 +1,11 @@
>  config W35UND
> -	tristate "Winbond driver"
> -	depends on MAC80211 && WLAN_80211 && USB && EXPERIMENTAL && !4KSTACKS
> +	tristate "IS89C35 WLAN USB driver"
> +	depends on MAC80211 && WLAN_80211 && USB && EXPERIMENTAL
>  	default n
>  	---help---
> -	  This is highly experimental driver for winbond wifi card on some Kohjinsha notebooks
> -	  Check http://code.google.com/p/winbondport/ for new version
> +	  This is highly experimental driver for Winbond WIFI card.
> +
> +	  HW is present in some Kohjinsha subnotebooks, and in some 

Please spell out "Hardware".
And check for whitespace at ends of lines.

> +	  stand-alone USB modules. Chipset name seems to be w89c35d.
> +
> +	  Check http://code.google.com/p/winbondport/ for new version.


-- 
~Randy

Re: w35und: fix Kconfig

[Pavel Machek]

4KSTACK dependency was needed when driver carried its own softmac
layer. That layer is gone, and functions have reasonably small stack
footprint -> dependency can be removed.

Add better description of hardware this driver is targetted at (now
with fixed whitespace)

Signed-off-by: Pavel Machek <pavel@suse.cz>
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>

diff -ur gregkh-ofic/drivers/staging/winbond/Kconfig gregkh/drivers/staging/winbond/Kconfig
--- gregkh-ofic/drivers/staging/winbond/Kconfig	2008-11-19 11:39:38.000000000 +0100
+++ gregkh/drivers/staging/winbond/Kconfig	2008-11-26 10:33:36.000000000 +0100
@@ -1,7 +1,11 @@
 config W35UND
-	tristate "Winbond driver"
-	depends on MAC80211 && WLAN_80211 && USB && EXPERIMENTAL && !4KSTACKS
+	tristate "IS89C35 WLAN USB driver"
+	depends on MAC80211 && WLAN_80211 && USB && EXPERIMENTAL
 	default n
 	---help---
-	  This is highly experimental driver for winbond wifi card on some Kohjinsha notebooks
-	  Check http://code.google.com/p/winbondport/ for new version
+	  This is highly experimental driver for Winbond WIFI card.
+
+	  Hardware is present in some Kohjinsha subnotebooks, and in some
+	  stand-alone USB modules. Chipset name seems to be w89c35d.
+
+	  Check http://code.google.com/p/winbondport/ for new version.

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: w35und: fix Kconfig

[Greg KH]

On Wed, Nov 26, 2008 at 05:15:16PM +0100, Pavel Machek wrote:
> 
> 4KSTACK dependency was needed when driver carried its own softmac
> layer. That layer is gone, and functions have reasonably small stack
> footprint -> dependency can be removed.
> 
> Add better description of hardware this driver is targetted at (now
> with fixed whitespace)

My scripts automatically strip off trailing whitespace (well, quilt
does), so this wasn't that necessary.  But I've now replaced the version
of this patch in my tree with your new one.

thanks,

greg k-h