From: "H. Peter Anvin" <hpa@zytor.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Hitoshi Mitake <h.mitake@gmail.com>,
Russell King <rmk+lkml@arm.linux.org.uk>,
Ralf Baechle <ralf@linux-mips.org>,
Andrew Morton <akpm@linux-foundation.org>,
Doug Thompson <norsk5@yahoo.com>,
"dougthompson@xmission.com" <dougthompson@xmission.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>
Subject: Re: [PATCH 1/1] edac x38: new MC driver module
Date: Mon, 24 Nov 2008 10:02:40 -0800 [thread overview]
Message-ID: <492AEC40.5060009@zytor.com> (raw)
In-Reply-To: <57C9024A16AD2D4C97DC78E552063EA35C517F42@orsmsx505.amr.corp.intel.com>
Luck, Tony wrote:
>> volatile u32 __iomem *__p = addr;
>> u32 __l, __h;
>
> Do we really need all the "__" inside an inline function? Why
> not just call these "p", "l" and "h"?
Sorry, user space habit (in userspace, and in anything that can be
included from userspace, one needs the __ to keep the namespace clean.)
-hpa
next prev parent reply other threads:[~2008-11-24 18:06 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-17 21:39 [PATCH 1/1] edac x38: new MC driver module dougthompson
2008-10-20 23:32 ` Andrew Morton
2008-11-05 22:29 ` Hitoshi Mitake
2008-11-05 16:26 ` Doug Thompson
2008-11-07 0:46 ` Andrew Morton
2008-11-07 15:28 ` Hitoshi Mitake
2008-11-07 6:31 ` Andrew Morton
2008-11-07 15:38 ` Hitoshi Mitake
2008-11-07 7:11 ` Andrew Morton
2008-11-09 15:10 ` Hitoshi Mitake
2008-11-09 19:26 ` Andrew Morton
2008-11-11 6:11 ` Paul Mundt
2008-11-13 15:15 ` Hitoshi Mitake
2008-11-18 12:16 ` Ralf Baechle
2008-11-18 12:32 ` Russell King
2008-11-20 16:19 ` Hitoshi Mitake
2008-11-23 23:52 ` H. Peter Anvin
2008-11-24 17:18 ` Luck, Tony
2008-11-24 18:02 ` H. Peter Anvin [this message]
2008-11-25 2:55 ` Hitoshi Mitake
2008-11-25 5:13 ` H. Peter Anvin
2008-11-25 15:30 ` Hitoshi Mitake
2008-11-25 15:46 ` Geert Uytterhoeven
2008-11-25 16:10 ` Hitoshi Mitake
2008-11-29 0:11 ` Hitoshi Mitake
-- strict thread matches above, loose matches on Subject: below --
2008-11-29 0:56 H. Peter Anvin
2008-11-29 7:47 ` Hitoshi Mitake
2008-11-29 9:38 ` Ingo Molnar
2008-11-29 10:26 ` Hitoshi Mitake
2008-11-29 10:52 ` Sam Ravnborg
2008-11-29 13:24 ` Hitoshi Mitake
2008-11-29 18:01 ` Sam Ravnborg
2008-11-30 8:16 ` Hitoshi Mitake
2008-11-30 8:37 ` Ingo Molnar
2008-11-30 9:24 ` Ingo Molnar
2008-11-30 15:20 ` Hitoshi Mitake
2008-11-30 16:15 ` Ingo Molnar
2008-12-01 13:51 ` Hitoshi Mitake
2008-12-01 13:59 ` Ingo Molnar
2008-12-01 23:58 ` Hitoshi Mitake
2008-12-04 15:58 ` Hitoshi Mitake
2009-01-16 1:24 ` Hitoshi Mitake
2009-02-21 10:11 ` Hitoshi Mitake
2009-02-21 10:39 ` Russell King
2009-02-21 13:09 ` Sam Ravnborg
2009-02-22 14:15 ` Hitoshi Mitake
2009-02-22 14:16 ` Hitoshi Mitake
2009-02-22 14:18 ` Hitoshi Mitake
2009-02-22 14:19 ` Hitoshi Mitake
2009-02-22 14:20 ` Hitoshi Mitake
2009-02-22 14:21 ` Hitoshi Mitake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492AEC40.5060009@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=dougthompson@xmission.com \
--cc=h.mitake@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=norsk5@yahoo.com \
--cc=ralf@linux-mips.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox