From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752773AbYKYTek (ORCPT ); Tue, 25 Nov 2008 14:34:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751553AbYKYTeb (ORCPT ); Tue, 25 Nov 2008 14:34:31 -0500 Received: from rcsinet12.oracle.com ([148.87.113.124]:34672 "EHLO rgminet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750816AbYKYTea (ORCPT ); Tue, 25 Nov 2008 14:34:30 -0500 Message-ID: <492C5334.2090801@oracle.com> Date: Tue, 25 Nov 2008 11:34:12 -0800 From: Randy Dunlap User-Agent: Thunderbird 2.0.0.17 (X11/20080914) MIME-Version: 1.0 To: Alan Cox CC: Randy Dunlap , Kamalesh Babulal , Stephen Rothwell , linux-next@vger.kernel.org, LKML , p_gortmaker@yahoo.com, netdev@vger.kernel.org, mel@csn.ul.ie Subject: Re: [BUILD_FAILURE] linux-next: 20081125 - 8390 network driver build fails References: <20081125213738.881b425e.sfr@canb.auug.org.au> <20081125182542.GA4914@linux.vnet.ibm.com> <492C464D.4080704@oracle.com> <20081125185154.2845e8f1@lxorguk.ukuu.org.uk> In-Reply-To: <20081125185154.2845e8f1@lxorguk.ukuu.org.uk> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit X-Source-IP: acsmt703.oracle.com [141.146.40.81] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090201.492C5332.0106:SCFSTAT928724,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alan Cox wrote: >> I just reported this on netdev and said that DaveM might want to drop a patch >> that I had submitted. Anyway, I'm looking into it. > > Ditto and the only sane interpretation I can see is that someone > somewhere has crap in their tree that does > > #define static > > and this is leaking out. The problem is that both 8390.c and 8390p.c #include lib8390.c and when they are both linked to built-in drivers (not loadable modules), the symbols in lib8390.c are duplicated. I think. ~Randy