From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753347AbYKYUJa (ORCPT ); Tue, 25 Nov 2008 15:09:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752132AbYKYUJS (ORCPT ); Tue, 25 Nov 2008 15:09:18 -0500 Received: from acsinet11.oracle.com ([141.146.126.233]:50436 "EHLO acsinet11.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752121AbYKYUJR (ORCPT ); Tue, 25 Nov 2008 15:09:17 -0500 X-Greylist: delayed 5396 seconds by postgrey-1.27 at vger.kernel.org; Tue, 25 Nov 2008 15:09:16 EST Message-ID: <492C5B52.6090803@oracle.com> Date: Tue, 25 Nov 2008 12:08:50 -0800 From: Randy Dunlap User-Agent: Thunderbird 2.0.0.17 (X11/20080914) MIME-Version: 1.0 To: Alan Cox CC: Randy Dunlap , Kamalesh Babulal , Stephen Rothwell , linux-next@vger.kernel.org, LKML , p_gortmaker@yahoo.com, netdev@vger.kernel.org, mel@csn.ul.ie, shemminger@linux-foundation.org Subject: Re: [BUILD_FAILURE] linux-next: 20081125 - 8390 network driver build fails References: <20081125213738.881b425e.sfr@canb.auug.org.au> <20081125182542.GA4914@linux.vnet.ibm.com> <492C464D.4080704@oracle.com> <20081125185154.2845e8f1@lxorguk.ukuu.org.uk> <492C5334.2090801@oracle.com> <20081125193853.076c7b58@lxorguk.ukuu.org.uk> <492C562E.9090302@oracle.com> <20081125195756.12317499@lxorguk.ukuu.org.uk> In-Reply-To: <20081125195756.12317499@lxorguk.ukuu.org.uk> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit X-Source-IP: acsmt702.oracle.com [141.146.40.80] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090208.492C5B50.0243:SCFSTAT928724,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alan Cox wrote: >> drivers/net/8390p.o: In function `ei_get_stats': >> (.text+0x1050): multiple definition of `ei_get_stats' >> drivers/net/8390.o:(.text+0xe20): first defined here >> drivers/net/8390p.o: In function `ei_start_xmit': >> (.text+0x1100): multiple definition of `ei_start_xmit' >> drivers/net/8390.o:(.text+0xef0): first defined here >> drivers/net/8390p.o: In function `ei_tx_timeout': >> (.text+0xec0): multiple definition of `ei_tx_timeout' >> drivers/net/8390.o:(.text+0xce0): first defined here >> drivers/net/8390p.o: In function `ei_set_multicast_list': >> (.text+0x1000): multiple definition of `ei_set_multicast_list' >> drivers/net/8390.o:(.text+0xea0): first defined here >> make[2]: *** [drivers/net/built-in.o] Error 1 >> >> and none of these functions is static in lib8390.c. > > They seem to be just fine in the base tree, so somebody has merged > something stoopid. > > > */ > > static int ei_start_xmit(struct sk_buff *skb, struct net_device *dev) > { OK, ack that, thanks. Looks like it's due to CONFIG_COMPAT_NET_DEV_OPS. Dave, no need to drop my hp-plus driver patch. ~Randy