public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Stable Kernel <stable@kernel.org>
Cc: "Ingo Molnar" <mingo@elte.hu>,
	"Daniel Schröder" <mail@dschroeder.info>,
	"Yinghai Lu" <yinghai@kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Change 5c371b31be3203 in stable breaks Xen
Date: Tue, 25 Nov 2008 13:26:37 -0800	[thread overview]
Message-ID: <492C6D8D.3040600@goop.org> (raw)

I have a report of Xen breaking between 2.6.27.5 and .6.  I bisected it 
down to change:

commit 5c371b31be32033b0a4a993431484da8a2305369
Author: Yinghai Lu <yhlu.kernel@gmail.com>
Date:   Mon Sep 22 02:52:26 2008 -0700

    x86: fix CONFIG_X86_RESERVE_LOW_64K=y
   
    commit 2216d199b1430d1c0affb1498a9ebdbd9c0de439 upstream
   
    The bad_bios_dmi_table() quirk never triggered because we do DMI setup
    too late. Move it a bit earlier.
   
    Also change the CONFIG_X86_RESERVE_LOW_64K quirk to operate on the e820
    table directly instead of messing with early reservations - this handles
    overlaps (which do occur in this low range of RAM) more gracefully.
   
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

I haven't completely root-caused why this is OK in mainline but failing 
in stable, but this patch works around the problem.

Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>

diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c
index 455575b..abed1dd 100644
--- a/drivers/firmware/dmi_scan.c
+++ b/drivers/firmware/dmi_scan.c
@@ -7,6 +7,7 @@
 #include <linux/bootmem.h>
 #include <linux/slab.h>
 #include <asm/dmi.h>
+#include <asm/xen/hypervisor.h>
 
 /*
  * DMI stands for "Desktop Management Interface".  It is part
@@ -364,6 +365,11 @@ void __init dmi_scan_machine(void)
        char __iomem *p, *q;
        int rc;
 
+#ifdef CONFIG_XEN
+       if (is_running_on_xen())
+               return;
+#endif
+
        if (efi_enabled) {
                if (efi.smbios == EFI_INVALID_TABLE_ADDR)
                        goto out;



             reply	other threads:[~2008-11-25 21:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-25 21:26 Jeremy Fitzhardinge [this message]
2008-11-25 23:06 ` Change 5c371b31be3203 in stable breaks Xen Ian Campbell
2008-11-25 23:25   ` Jeremy Fitzhardinge
2008-11-26  0:03     ` [stable] " Greg KH
2008-11-26 20:41       ` Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=492C6D8D.3040600@goop.org \
    --to=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mail@dschroeder.info \
    --cc=mingo@elte.hu \
    --cc=stable@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox