Re: [PATCH] markers: comment marker_synchronize_unregister() on data dependency

Ingo Molnar
2008-11-28T15:48:44Z

* Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> wrote:

> * Wu Fengguang (fengguang.wu@intel.com) wrote:
> > On Thu, Nov 27, 2008 at 10:00:03AM +0200, Mathieu Desnoyers wrote:
> > > * Wu Fengguang (fengguang.wu@intel.com) wrote:
> > > > +
> > > > +marker_synchronize_unregister() must be called before the first occurrence of
> > >
> > >
> > > You should probably say
> > >
> > > ".. must be called between probe unregistration and the first occurence
> > > of..."
> > >
> > > Mathieu
> >
> > That's much better!
> >
> > With your comments I'd assume you reviewed this patch ;-)
> >
> > Thanks,
> > Fengguang
> > ---
> > markers: comment marker_synchronize_unregister() on data dependency
> >
> > Add document and comments on marker_synchronize_unregister(): it
> > should be called before freeing resources that the probes depend on.
> >
> > Based on comments from Lai Jiangshan and Mathieu Desnoyers.
> >
> > Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
> > Reviewed-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> > Signed-off-by: Wu Fengguang <wfg@linux.intel.com>
>
> It looks good to me, thanks!
>
> Acked-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>

applied to tip/tracing/markers, thanks guys!

Ingo