* [PATCH] sm501: unsigned ptr cannot be negative
@ 2008-11-29 11:49 roel kluin
2008-12-02 22:05 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: roel kluin @ 2008-11-29 11:49 UTC (permalink / raw)
To: ben-linux; +Cc: linux-kernel
unsigned ptr cannot be negative
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/video/sm501fb.c b/drivers/video/sm501fb.c
index f94ae84..dcd9879 100644
--- a/drivers/video/sm501fb.c
+++ b/drivers/video/sm501fb.c
@@ -159,6 +159,9 @@ static int sm501_alloc_mem(struct sm501fb_info *inf, struct sm501_mem *mem,
break;
case SM501_MEMF_PANEL:
+ if (size > inf->fbmem_len)
+ return -ENOMEM;
+
ptr = inf->fbmem_len - size;
fbi = inf->fb[HEAD_CRT];
@@ -172,9 +175,6 @@ static int sm501_alloc_mem(struct sm501fb_info *inf, struct sm501_mem *mem,
if (fbi && ptr < fbi->fix.smem_len)
return -ENOMEM;
- if (ptr < 0)
- return -ENOMEM;
-
break;
case SM501_MEMF_CRT:
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sm501: unsigned ptr cannot be negative
2008-11-29 11:49 [PATCH] sm501: unsigned ptr cannot be negative roel kluin
@ 2008-12-02 22:05 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2008-12-02 22:05 UTC (permalink / raw)
To: roel kluin; +Cc: ben-linux, linux-kernel
On Sat, 29 Nov 2008 06:49:20 -0500
roel kluin <roel.kluin@gmail.com> wrote:
> unsigned ptr cannot be negative
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/drivers/video/sm501fb.c b/drivers/video/sm501fb.c
> index f94ae84..dcd9879 100644
> --- a/drivers/video/sm501fb.c
> +++ b/drivers/video/sm501fb.c
> @@ -159,6 +159,9 @@ static int sm501_alloc_mem(struct sm501fb_info *inf, struct sm501_mem *mem,
> break;
>
> case SM501_MEMF_PANEL:
> + if (size > inf->fbmem_len)
> + return -ENOMEM;
> +
> ptr = inf->fbmem_len - size;
> fbi = inf->fb[HEAD_CRT];
>
> @@ -172,9 +175,6 @@ static int sm501_alloc_mem(struct sm501fb_info *inf, struct sm501_mem *mem,
> if (fbi && ptr < fbi->fix.smem_len)
> return -ENOMEM;
>
> - if (ptr < 0)
> - return -ENOMEM;
> -
> break;
>
> case SM501_MEMF_CRT:
Looks OK.
Also this:
if (ptr > 0)
ptr &= ~(PAGE_SIZE - 1);
could just be
ptr = PAGE_ALIGN(ptr);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-02 22:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-29 11:49 [PATCH] sm501: unsigned ptr cannot be negative roel kluin
2008-12-02 22:05 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox