Re: [PATCH 04/11] make get_scan_ratio() to memcg safe

Rik van Riel
2008-12-01T14:50:57Z

KOSAKI Motohiro wrote:
> Currently, get_scan_ratio() always calculate the balancing value for global reclaim and
> memcg reclaim doesn't use it.
> Therefore it doesn't have scan_global_lru() condition.
>
> However, we plan to expand get_scan_ratio() to be usable for memcg too, latter.
> Then, The dependency code of global reclaim in the get_scan_ratio() insert into
> scan_global_lru() condision explictly.
>
>
> this patch doesn't have any functional change.
>
>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>

Good in principle, though of course this particular corner
case is not going to change when reclaiming a memcg :)

Acked-by: Rik van Riel <riel@redhat.com>

--
All rights reversed.