Re: [PATCH 11/11] memcg: show reclaim_stat

KAMEZAWA Hiroyuki
2008-12-03T16:15:50Z

Balbir Singh said:
> * KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> [2008-12-02
> 18:05:25]:
>
>> On Mon, 1 Dec 2008 21:19:49 +0900 (JST)
>> KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
>>
>> > added following four field to memory.stat file.
>> >
>> > - recent_rotated_anon
>> > - recent_rotated_file
>> > - recent_scanned_anon
>> > - recent_scanned_file
>> >
>> > it is useful for memcg reclaim debugging.
>> >
>> I'll put this under CONFIG_DEBUG_VM.
>>
>
> I think they'll be useful even outside for tasks that need to take
> decisions, it will be nice to see what sort of reclaim is going on.
There are already pgin/pgout value.

> I
> would like to see them outside, there is no cost associated with them
> and assuming we'll not change the LRU logic very frequently, we don't
> need to be afraid of breaking ABI either :)
>
There are 2 reasons to put this under DEBUG
1. This is not exported as this value under /proc by global VM management.
2. Few people can explain what this really means. No documentation in
Docunemtation/ directory. I can't add precise explanation by myself.
As Kosaki wrote, this is for his debug, IMHO.

If you want to show this, please add above two first.

Thanks,
-Kame