From: Mark Lord <lkml@rtr.ca>
To: Len Brown <lenb@kernel.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
David Brownell <david-b@pacbell.net>,
lkml <linux-kernel@vger.kernel.org>,
rtc-linux@googlegroups.com, linux-acpi@vger.kernel.org
Subject: Re: PATCH: /proc/acpi/alarm: handle day-of-month wraparound on readback
Date: Mon, 01 Dec 2008 17:15:46 -0500 [thread overview]
Message-ID: <49346212.3050102@rtr.ca> (raw)
In-Reply-To: <alpine.LFD.2.00.0812011311490.3197@localhost.localdomain>
Len Brown wrote:
> I don't have a /proc/acpi/alarm due to this:
>
> #if defined(CONFIG_RTC_DRV_CMOS) || defined(CONFIG_RTC_DRV_CMOS_MODULE) ||
> !defined(CONFIG_X86)
> /* use /sys/class/rtc/rtcX/wakealarm instead; it's not ACPI-specific */
> #else
> #define HAVE_ACPI_LEGACY_ALARM
> #endif
..
Yeah.. bit of a nuisance that.
I regularly apply this patch to my own kernels:
--- old/drivers/acpi/sleep/proc.c 2008-01-06 16:39:45.000000000 -0500
+++ linux/drivers/acpi/sleep/proc.c 2008-01-06 17:35:35.000000000 -0500
@@ -78,11 +78,11 @@
}
#endif /* CONFIG_ACPI_PROCFS */
-#if defined(CONFIG_RTC_DRV_CMOS) || defined(CONFIG_RTC_DRV_CMOS_MODULE) || !defined(CONFIG_X86)
+//#if defined(CONFIG_RTC_DRV_CMOS) || defined(CONFIG_RTC_DRV_CMOS_MODULE) || !defined(CONFIG_X86)
/* use /sys/class/rtc/rtcX/wakealarm instead; it's not ACPI-specific */
-#else
+//#else
#define HAVE_ACPI_LEGACY_ALARM
-#endif
+//#endif
#ifdef HAVE_ACPI_LEGACY_ALARM
next prev parent reply other threads:[~2008-12-01 22:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-23 3:42 [patch 2.6.26-rc7] rtc_read_alarm() handles wraparound David Brownell
2008-06-25 8:59 ` [rtc-linux] " Alessandro Zummo
2008-12-01 16:57 ` PATCH: /proc/acpi/alarm: handle day-of-month wraparound on readback Mark Lord
2008-12-01 17:02 ` Mark Lord
2008-12-02 10:29 ` Tino Keitel
2008-12-02 18:54 ` Mark Lord
2008-12-01 18:18 ` Len Brown
2008-12-01 22:13 ` Mark Lord
2008-12-09 15:46 ` [PATCH] " Mark Lord
2008-12-10 5:35 ` Len Brown
2008-12-01 22:15 ` Mark Lord [this message]
2008-12-01 22:32 ` [rtc-linux] Re: PATCH: " Alessandro Zummo
2008-12-02 18:57 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49346212.3050102@rtr.ca \
--to=lkml@rtr.ca \
--cc=a.zummo@towertech.it \
--cc=david-b@pacbell.net \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox