public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Steven Rostedt <srostedt@redhat.com>
Cc: Luis Henriques <henrix@sapo.pt>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [BUG] kvm crashes in 2.6.28-rc6-00007-ged31348
Date: Tue, 02 Dec 2008 22:56:31 +0200	[thread overview]
Message-ID: <4935A0FF.7070105@redhat.com> (raw)
In-Reply-To: <1228250921.4886.14.camel@localhost.localdomain>

Steven Rostedt wrote:

  

>> In arch/x86/kvm/svm.c, function svm_vcpu_run(), everything between the 
>> vmrun instruction and the call to load_host_msrs() is executed without a 
>> live pda, so no smp_processor_id().  Could easily be fixed by 
>> rearranging things.
>>     
>
> That would be best, but if you have trouble, you could surround the
> trouble area with a: tracing_stop(); tracing_start(); That will prevent
> tracing within those locations. The function tracer will still be
> called, but it will exit the function without doing anything else.
>
> Note: that stops tracing on all CPUS, not just the CPU that called it.
>   

The vmrun instruction can execute for a long time (hours, if you have a 
dyntick kernel and no timers scheduled), so that's less than optimal.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.


  reply	other threads:[~2008-12-02 20:58 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-30 19:34 [BUG] kvm crashes in 2.6.28-rc6-00007-ged31348 Luis Henriques
2008-11-30 20:20 ` Avi Kivity
2008-11-30 20:38   ` Luis Henriques
2008-11-30 20:44     ` Avi Kivity
2008-11-30 21:04       ` Luis Henriques
2008-12-02 12:23         ` Avi Kivity
2008-12-02 12:25           ` Avi Kivity
2008-12-02 12:31             ` Avi Kivity
2008-12-02 19:09           ` Luis Henriques
2008-12-02 19:27             ` Avi Kivity
2008-12-02 19:30             ` Avi Kivity
2008-12-02 19:46             ` Luis Henriques
2008-12-02 20:25               ` Steven Rostedt
2008-12-02 20:38                 ` Avi Kivity
2008-12-02 20:48                   ` Steven Rostedt
2008-12-02 20:56                     ` Avi Kivity [this message]
2008-12-04 15:36                   ` Avi Kivity
2008-12-04 22:05                     ` Luis Henriques
2008-12-02 20:46                 ` Luis Henriques
2008-12-02 21:16                   ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4935A0FF.7070105@redhat.com \
    --to=avi@redhat.com \
    --cc=henrix@sapo.pt \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=srostedt@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox