From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753092AbYLCJEz (ORCPT ); Wed, 3 Dec 2008 04:04:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751503AbYLCJEe (ORCPT ); Wed, 3 Dec 2008 04:04:34 -0500 Received: from hera.kernel.org ([140.211.167.34]:43753 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753520AbYLCJEc (ORCPT ); Wed, 3 Dec 2008 04:04:32 -0500 Message-ID: <49364B93.5000409@kernel.org> Date: Wed, 03 Dec 2008 18:04:19 +0900 From: Tejun Heo User-Agent: Thunderbird 2.0.0.17 (X11/20080922) MIME-Version: 1.0 To: Jiri Slaby CC: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Jeff Garzik , Alexandru Romanescu Subject: Re: [PATCH 1/1] ATA: piix, fix pointer deref on suspend References: <1228292026-23586-1-git-send-email-jirislaby@gmail.com> In-Reply-To: <1228292026-23586-1-git-send-email-jirislaby@gmail.com> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (hera.kernel.org [127.0.0.1]); Wed, 03 Dec 2008 09:03:49 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jiri Slaby wrote: > Hi, > > I've found this issue in the mmotm 2008-12-02-17-08. > > -- > > Commit > ata_piix: add borked Tecra M4 to broken suspend list > introduced DMI variables checking, but they can be null, so that > we possibly dereference null. > > Check if they are null and avoid checks in that case. > > Solves: > BUG: unable to handle kernel NULL pointer dereference at 0000000000000000 > IP: [] piix_pci_device_suspend+0x117/0x230 > > Signed-off-by: Jiri Slaby > Cc: Jeff Garzik > Cc: Alexandru Romanescu > Cc: Tejun Heo Thanks. Acked-by: Tejun Heo -- tejun