From: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Matt_Domsch@dell.com,
greg@kroah.com, linux-acpi@vger.kernel.org,
Richard Purdie <rpurdie@rpsys.net>,
Ivo van Doorn <ivdoorn@gmail.com>
Subject: Re: [PATCH 2/2 update] misc: Add dell-laptop driver
Date: Wed, 03 Dec 2008 12:37:22 +0000 [thread overview]
Message-ID: <49367D82.8040305@tuffmail.co.uk> (raw)
In-Reply-To: <20081202201645.GB31620@srcf.ucam.org>
Matthew Garrett wrote:
> misc: Add dell-laptop driver
>
> Add a driver for controling Dell-specific backlight and rfkill interfaces.
> This driver makes use of the dcdbas interface to the Dell firmware to allow
> the backlight and rfkill interfaces on Dell systems to be driven through the
> standardised sysfs interfaces.
>
> Signed-off-by: Matthew Garrett <mjg@redhat.com>
>
> ---
>
> Contains Andrew's suggested updates, plus a fix for a leak on the init
> error path.
>
I see you don't call rfkill_set_default(). Do Dell firmwares support
persistent rfkill state?
My ill-informed guess is that it shouldn't hurt to call it. If the
firmware is sane, it will initialize the rfkill to a useful state.
Otherwise, the radio(s) would be unusable without the platform driver.
But do feel free to ignore me, if you suspect the firmware of insanity :).
Regards
Alan
next prev parent reply other threads:[~2008-12-03 12:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-27 16:33 [PATCH 1/2] dcdbas: Export functionality for use in other drivers Matthew Garrett
2008-11-27 16:34 ` [PATCH 2/2] misc: Add dell-laptop driver Matthew Garrett
2008-12-02 17:02 ` Matt Domsch
2008-12-02 17:03 ` Matthew Garrett
2008-12-02 19:50 ` Andrew Morton
2008-12-02 20:05 ` Matthew Garrett
2008-12-02 20:22 ` Andrew Morton
2008-12-02 20:30 ` Matthew Garrett
2008-12-02 20:16 ` [PATCH 2/2 update] " Matthew Garrett
2008-12-03 12:37 ` Alan Jenkins [this message]
2008-12-03 13:01 ` none
2008-12-05 2:05 ` Henrique de Moraes Holschuh
2008-12-03 19:14 ` Len Brown
2008-12-03 19:52 ` Matthew Garrett
2008-12-04 9:12 ` Sven Wegener
2008-12-04 11:00 ` Alan Jenkins
2008-12-05 2:08 ` Henrique de Moraes Holschuh
2008-12-02 3:52 ` [PATCH 1/2] dcdbas: Export functionality for use in other drivers Greg KH
2008-12-02 4:03 ` Matthew Garrett
2008-12-02 17:03 ` Matt Domsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49367D82.8040305@tuffmail.co.uk \
--to=alan-jenkins@tuffmail.co.uk \
--cc=Matt_Domsch@dell.com \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=ivdoorn@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox