[PATCH 1/1] Char: n_tty, include module.h

[PATCH 1/1] Char: n_tty, include module.h

[Jiri Slaby]

Since we are using EXPORT_SYMBOL, we should include linux/module.h

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
---
 drivers/char/n_tty.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/char/n_tty.c b/drivers/char/n_tty.c
index b441c09..8e6c591 100644
--- a/drivers/char/n_tty.c
+++ b/drivers/char/n_tty.c
@@ -41,6 +41,7 @@
 #include <linux/timer.h>
 #include <linux/ctype.h>
 #include <linux/mm.h>
+#include <linux/module.h>
 #include <linux/string.h>
 #include <linux/slab.h>
 #include <linux/poll.h>
-- 
1.6.0.4

Re: [PATCH 1/1] Char: n_tty, include module.h

[Alan Cox]

On Wed,  3 Dec 2008 13:28:58 +0100
Jiri Slaby <jirislaby@gmail.com> wrote:

> Since we are using EXPORT_SYMBOL, we should include linux/module.h
> 
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>

NAK

n_tty doesn't use EXPORT_SYMBOL.

Alan

Re: [PATCH 1/1] Char: n_tty, include module.h

[Jiri Slaby]

On 12/03/2008 01:43 PM, Alan Cox wrote:
> On Wed,  3 Dec 2008 13:28:58 +0100
> Jiri Slaby <jirislaby@gmail.com> wrote:
> 
>> Since we are using EXPORT_SYMBOL, we should include linux/module.h
>>
>> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
> 
> NAK
> 
> n_tty doesn't use EXPORT_SYMBOL.

Sure it does. Maybe the patch didn't come to you yet. Will repost to akpm as a
ldisc-n_tty-export-all-n_tty-ldisc-methods.patch fix.

$ grep EXPORT drivers/char/n_tty.c
EXPORT_SYMBOL_GPL(n_tty_flush_buffer);
EXPORT_SYMBOL_GPL(n_tty_chars_in_buffer);
EXPORT_SYMBOL_GPL(n_tty_write_wakeup);
EXPORT_SYMBOL_GPL(n_tty_receive_buf);
EXPORT_SYMBOL_GPL(n_tty_set_termios);
EXPORT_SYMBOL_GPL(n_tty_close);
EXPORT_SYMBOL_GPL(n_tty_open);
EXPORT_SYMBOL_GPL(n_tty_read);
EXPORT_SYMBOL_GPL(n_tty_write);
EXPORT_SYMBOL_GPL(n_tty_poll);

Re: [PATCH 1/1] Char: n_tty, include module.h

[Alan Cox]

On Wed, 03 Dec 2008 16:17:52 +0100
Jiri Slaby <jirislaby@gmail.com> wrote:

> On 12/03/2008 01:43 PM, Alan Cox wrote:
> > On Wed,  3 Dec 2008 13:28:58 +0100
> > Jiri Slaby <jirislaby@gmail.com> wrote:
> > 
> >> Since we are using EXPORT_SYMBOL, we should include linux/module.h
> >>
> >> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
> > 
> > NAK
> > 
> > n_tty doesn't use EXPORT_SYMBOL.
> 
> Sure it does. Maybe the patch didn't come to you yet. Will repost to akpm as a
> ldisc-n_tty-export-all-n_tty-ldisc-methods.patch fix

And that patch isn't going in either. Ask Andrew to drop it instead. If
the rest of the PPS stuff goes in then I'll redo that part of the n_tty
stuff differently and cleanly.

Alan

Re: [PATCH 1/1] Char: n_tty, include module.h

[Jiri Slaby]

Alan Cox napsal(a):
> On Wed, 03 Dec 2008 16:17:52 +0100
> Jiri Slaby <jirislaby@gmail.com> wrote:
> 
>> On 12/03/2008 01:43 PM, Alan Cox wrote:
>>> On Wed,  3 Dec 2008 13:28:58 +0100
>>> Jiri Slaby <jirislaby@gmail.com> wrote:
>>>
>>>> Since we are using EXPORT_SYMBOL, we should include linux/module.h
>>>>
>>>> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
>>> NAK
>>>
>>> n_tty doesn't use EXPORT_SYMBOL.
>> Sure it does. Maybe the patch didn't come to you yet. Will repost to akpm as a
>> ldisc-n_tty-export-all-n_tty-ldisc-methods.patch fix
> 
> And that patch isn't going in either. Ask Andrew to drop it instead. If
> the rest of the PPS stuff goes in then I'll redo that part of the n_tty
> stuff differently and cleanly.

Fair enough. Andrew, could you?