Re: BUG? "Call fasync() functions without the BKL" is racy

Andi Kleen
2008-12-03T21:20:56Z

>> I wonder if we need FASYNC at all. This could be gotten implicitely by
>> looking at the fasync_list
>
> Only if socket.

But the helpers used by the character drivers add it too I think.

> Serioulsy, I think the best (partial, yes) fix for now is to restore
> lock_kernel() in setfl() and change ioctl_fioxxx() accordingly.
> At least this protect us from tty too.

For 2.6.28 I agree.

> Not that I think this is very good idea though ;)

The lock bit sounds reasonable.

-Andi