public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Jody McIntyre <scjody@sun.com>,
	linux-kernel@vger.kernel.org, tglx@linutronix.de,
	mingo@redhat.com
Subject: Re: [PATCH] Fix compile error in arch/x86/kernel/syscall_64.c
Date: Thu, 04 Dec 2008 11:12:05 -0800	[thread overview]
Message-ID: <49382B85.1020803@zytor.com> (raw)
In-Reply-To: <200812041533.00736.arnd@arndb.de>

Arnd Bergmann wrote:
> On Tuesday 02 December 2008, Jody McIntyre wrote:
>> 1965aae3c98397aad957412413c07e97b1bd4e64 broke compilation on one of my
>> systems:
>>
>>   CC      arch/x86/kernel/syscall_64.o
>> arch/x86/kernel/syscall_64.c:27: error: array index in initializer exceeds array bounds
>> arch/x86/kernel/syscall_64.c:27: error: (near initialization for ‘sys_call_table’)
>> arch/x86/kernel/syscall_64.c:27: warning: excess elements in array initializer
>> arch/x86/kernel/syscall_64.c:27: warning: (near initialization for ‘sys_call_table’)
>> make[1]: *** [arch/x86/kernel/syscall_64.o] Error 1
>> make: *** [arch/x86/kernel/syscall_64.o] Error 2
>>
>> Reverting only the parts of the commit that change ASM_X86__UNISTD_64_H
>> to _ASM_X86_UNISTD_64_H fixes the problem.  Patch below.
>>
>> I have no idea what's going on here.  Compiler bug?
> 
> Maybe you have stale header files in include/asm-x86/? That sometimes
> happens if you git-checkout -f or git-reset --hard.
> 

"git cleanup" should be used to catch that classes of problems.  I did
notice that the include file trace used include/asm not
arch/x86/include/asm, which to me implies something like this.

I just tried, and when I make a .i file on a clean tree I get:

# 10 "<full path>/arch/x86/include/asm/posix_types_64.h"

not

# 10 "include/asm/posix_types_64.h"

as the posted .i file has.

	-hpa

      parent reply	other threads:[~2008-12-04 19:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-02 21:51 [PATCH] Fix compile error in arch/x86/kernel/syscall_64.c Jody McIntyre
2008-12-03 18:00 ` H. Peter Anvin
2008-12-03 19:50   ` Jody McIntyre
2008-12-03 20:17     ` H. Peter Anvin
2008-12-03 21:23       ` Jody McIntyre
2008-12-04 14:32 ` Arnd Bergmann
2008-12-04 19:07   ` Jody McIntyre
2008-12-04 19:12   ` H. Peter Anvin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49382B85.1020803@zytor.com \
    --to=hpa@zytor.com \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=scjody@sun.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox