From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759101AbYLDWVb (ORCPT ); Thu, 4 Dec 2008 17:21:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757900AbYLDWVH (ORCPT ); Thu, 4 Dec 2008 17:21:07 -0500 Received: from hera.kernel.org ([140.211.167.34]:56399 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757508AbYLDWVG (ORCPT ); Thu, 4 Dec 2008 17:21:06 -0500 Message-ID: <493857B5.8000104@kernel.org> Date: Thu, 04 Dec 2008 14:20:37 -0800 From: Yinghai Lu User-Agent: Thunderbird 2.0.0.18 (X11/20081112) MIME-Version: 1.0 To: Andi Kleen CC: Ingo Molnar , Wu Fengguang , LKML , Andrew Morton , Jack Steiner , "H. Peter Anvin" , Thomas Gleixner Subject: Re: 2.6.28-rc6: early panic with boot option "nosmp" References: <20081204022806.GA29293@localhost> <20081204101343.GO6703@one.firstfloor.org> <20081204120214.GA30833@localhost> <20081204123335.GP6703@one.firstfloor.org> <20081204153411.GA18306@elte.hu> <493846E1.7010104@kernel.org> <20081204220919.GU6703@one.firstfloor.org> In-Reply-To: <20081204220919.GU6703@one.firstfloor.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andi Kleen wrote: >> but smp_found_config is set acpi_boot_init.. with madt. >> >> could move that check earlier > > Then it wouldn't print the "Using ACPI foo" messages. I think it's better > to put it later like my patch did. > > BTW the function could really need splitting up, it seems to do lots > of unrelated things. should move those print out to acpi_boot_init(). YH