From: Jarod Wilson <jarod@redhat.com>
To: linux-crypto@vger.kernel.org
Cc: Neil Horman <nhorman@tuxdriver.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: des: fix inverted weak key flag check
Date: Fri, 05 Dec 2008 09:54:14 -0500 [thread overview]
Message-ID: <49394096.6080402@redhat.com> (raw)
In-Reply-To: <200812041555.22429.jarod@redhat.com>
Jarod Wilson wrote:
> Based on the fact the testmgr code sets the weak key flag for
> vectors with wk = 1, the weak key flag check in des_setkey()
> is backwards. Also, add a warning when a weak key is rejected,
> otherwise you silently get a bogus result back.
>
> Signed-off-by: Jarod Wilson <jarod@redhat.com>
Self-NAK. Due to mail server issues, this might show up before the
original...
My understanding of the flag's meaning appears to be backwards, Herbert
pointed out that the use of this flag is self-consistent. Also, the
printk probably shouldn't be there, the caller should check retval and
complain if need be.
--
Jarod Wilson
jarod@redhat.com
parent reply other threads:[~2008-12-05 14:51 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <200812041555.22429.jarod@redhat.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49394096.6080402@redhat.com \
--to=jarod@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox