From: Robert Hancock <hancockr@shaw.ca>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Frans Pop <elendil@planet.nl>, "Rafael J. Wysocki" <rjw@sisk.pl>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch] ohci1394: don't leave interrupts enabled during suspend/resume
Date: Sat, 06 Dec 2008 21:28:17 -0600 [thread overview]
Message-ID: <493B42D1.7090600@shaw.ca> (raw)
In-Reply-To: <tkrat.fd592eed61e41b8f@s5r6.in-berlin.de>
Stefan Richter wrote:
> Robert Hancock wrote:
>> If free_irq and
>> request_irq fix anything, then that indicates that the ohci1394 device
>> is generating interrupts at some point during resume,
> ...
>> Likely the driver should be setting some register on the device to
>> disable it from generating interrupts before suspend and it's not doing
>> this.
>
> reg_write(ohci, OHCI1394_IntMaskClear, 0xffffffff);
>
> in ohci1394's .suspend() switches interrupts off.
Presumably it should.. but the fact remains that if free_irq helps
anything, then the device must be generating interrupts for some reason,
and it's really just papering over the problem. Perhaps a quirk of that
particular chip? Something to do with the state it's in after resume?
next prev parent reply other threads:[~2008-12-07 3:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-06 12:16 ohci1394: "irq 19: nobody cared" during resume from suspend to ram Frans Pop
2008-12-06 13:11 ` Stefan Richter
2008-12-06 13:37 ` Frans Pop
2008-12-06 14:36 ` [patch] ohci1394: don't leave interrupts enabled during suspend/resume Frans Pop
2008-12-06 16:12 ` Stefan Richter
2008-12-06 21:03 ` Robert Hancock
[not found] ` <tkrat.fd592eed61e41b8f@s5r6.in-berlin.de>
2008-12-07 3:28 ` Robert Hancock [this message]
2008-12-07 9:19 ` Stefan Richter
2008-12-07 18:57 ` Robert Hancock
2008-12-10 13:24 ` Frans Pop
2008-12-10 20:55 ` Stefan Richter
2008-12-10 21:46 ` Frans Pop
2008-12-10 22:25 ` Stefan Richter
2008-12-11 16:02 ` Frans Pop
2008-12-10 13:23 ` Frans Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=493B42D1.7090600@shaw.ca \
--to=hancockr@shaw.ca \
--cc=elendil@planet.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox