[PATCH] bluetooth usb hci: ISSC usb dongle with buggy SCO support

[PATCH] bluetooth usb hci: ISSC usb dongle with buggy SCO support

[Luca Santarelli]

From: Luca Santarelli <hrk <t> users.sourceforge.net>

As reported at:
http://bugs.gentoo.org/show_bug.cgi?id=249523
and in reference of similar patches such as:
http://thread.gmane.org/gmane.linux.bluez.devel/15067

This patch changes the blacklist entry for the ISSC bluetooth USB
dongle fixing the issue of the repeatedly appearing message

  hci_scodata_packet: hci0 SCO packet for unknown connection handle 92

in the kernel logs.

Sighed-off-by: Luca Santarelli <hrk <at> users.sourceforge.net>
---
This is my first kernel patch ever, I read the docs, but please notify
me if I made any mistake. Thank you all for your work, I'm happy to have
been able to contribute to this!

The patch has been run against 2.6.27.7 and has been tested on three x86
machines, showing no issues. In my own tests, the dongle has been then
used to connect to devices and everything worked fine.

--- linux-2.6.27.7/drivers/bluetooth/hci_usb.c.orig	2008-12-04 20:18:38.000000000 +0100
+++ linux-2.6.27.7/drivers/bluetooth/hci_usb.c	2008-12-04 20:19:37.000000000 +0100
@@ -148,8 +148,8 @@ static struct usb_device_id blacklist_id
 	{ USB_DEVICE(0x047d, 0x105d), .driver_info = HCI_RESET },
 	{ USB_DEVICE(0x047d, 0x105e), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU },
 
-	/* ISSC Bluetooth Adapter v3.1 */
-	{ USB_DEVICE(0x1131, 0x1001), .driver_info = HCI_RESET },
+	/* ISSC Bluetooth Adapter v3.1 with buggy SCO support */
+	{ USB_DEVICE(0x1131, 0x1001), .driver_info = HCI_RESET | HCI_BROKEN_ISOC },
 
 	/* RTX Telecom based adapters with buggy SCO support */
 	{ USB_DEVICE(0x0400, 0x0807), .driver_info = HCI_BROKEN_ISOC },

Re: [PATCH] bluetooth usb hci: ISSC usb dongle with buggy SCO support

[Andrew Morton]

On Fri, 5 Dec 2008 00:02:13 +0100 Luca Santarelli <hrk@users.sourceforge.net> wrote:

> From: Luca Santarelli <hrk <t> users.sourceforge.net>
> 
> As reported at:
> http://bugs.gentoo.org/show_bug.cgi?id=249523
> and in reference of similar patches such as:
> http://thread.gmane.org/gmane.linux.bluez.devel/15067
> 
> This patch changes the blacklist entry for the ISSC bluetooth USB
> dongle fixing the issue of the repeatedly appearing message
> 
>   hci_scodata_packet: hci0 SCO packet for unknown connection handle 92
> 
> in the kernel logs.
> 
> Sighed-off-by: Luca Santarelli <hrk <at> users.sourceforge.net>
> ---
> This is my first kernel patch ever, I read the docs, but please notify
> me if I made any mistake. Thank you all for your work, I'm happy to have
> been able to contribute to this!
> 
> The patch has been run against 2.6.27.7 and has been tested on three x86
> machines, showing no issues. In my own tests, the dongle has been then
> used to connect to devices and everything worked fine.
> 
> --- linux-2.6.27.7/drivers/bluetooth/hci_usb.c.orig	2008-12-04 20:18:38.000000000 +0100
> +++ linux-2.6.27.7/drivers/bluetooth/hci_usb.c	2008-12-04 20:19:37.000000000 +0100
> @@ -148,8 +148,8 @@ static struct usb_device_id blacklist_id
>  	{ USB_DEVICE(0x047d, 0x105d), .driver_info = HCI_RESET },
>  	{ USB_DEVICE(0x047d, 0x105e), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU },
>  
> -	/* ISSC Bluetooth Adapter v3.1 */
> -	{ USB_DEVICE(0x1131, 0x1001), .driver_info = HCI_RESET },
> +	/* ISSC Bluetooth Adapter v3.1 with buggy SCO support */
> +	{ USB_DEVICE(0x1131, 0x1001), .driver_info = HCI_RESET | HCI_BROKEN_ISOC },
>  
>  	/* RTX Telecom based adapters with buggy SCO support */
>  	{ USB_DEVICE(0x0400, 0x0807), .driver_info = HCI_BROKEN_ISOC },

linux-next has:

commit 12421b40b81d101d7535e03f1af197365adc932b
Author: Marcel Holtmann <marcel@holtmann.org>
Date:   Sun Nov 30 12:17:21 2008 +0100

    Bluetooth: Remove deprecated hci_usb driver
    
    The old hci_usb driver has been fully replaced with the new btusb driver
    and all major distributions switched to the new driver now. This removes
    it since it should not be used at all anymore.

so please confirm that btusb correctly supports that hardware?

Re: [PATCH] bluetooth usb hci: ISSC usb dongle with buggy SCO support

[Daniel Drake]

Andrew Morton wrote:
> commit 12421b40b81d101d7535e03f1af197365adc932b
> Author: Marcel Holtmann <marcel@holtmann.org>
> Date:   Sun Nov 30 12:17:21 2008 +0100
> 
>     Bluetooth: Remove deprecated hci_usb driver
>     
>     The old hci_usb driver has been fully replaced with the new btusb driver
>     and all major distributions switched to the new driver now. This removes
>     it since it should not be used at all anymore.
> 
> so please confirm that btusb correctly supports that hardware?

And if it doesn't, it should be trivial to come up with an equivalent 
patch to modify blacklist_table in btusb.

Daniel

Re: [PATCH] bluetooth usb hci: ISSC usb dongle with buggy SCO support

[Luca Santarelli]

Il giorno 07/dic/08, alle ore 09:19, Andrew Morton ha scritto:

> linux-next has:
>
> commit 12421b40b81d101d7535e03f1af197365adc932b
> Author: Marcel Holtmann <marcel@holtmann.org>
> Date:   Sun Nov 30 12:17:21 2008 +0100
>
>    Bluetooth: Remove deprecated hci_usb driver
>
>    The old hci_usb driver has been fully replaced with the new btusb  
> driver
>    and all major distributions switched to the new driver now. This  
> removes
>    it since it should not be used at all anymore.
>
> so please confirm that btusb correctly supports that hardware?


Thanks for the heads up! I'll compile the new sources and let you know  
if it's supported. However, since the hci_usb is being deprecated but  
not removed, shouldn't the patch be incorporated nonetheless?

Luca

Re: [PATCH] bluetooth usb hci: ISSC usb dongle with buggy SCO support

[Markos Chandras]

On Tuesday 09 December 2008 01:07:35 Luca Santarelli wrote:
> Il giorno 07/dic/08, alle ore 09:19, Andrew Morton ha scritto:
> > linux-next has:
> >
> > commit 12421b40b81d101d7535e03f1af197365adc932b
> > Author: Marcel Holtmann <marcel@holtmann.org>
> > Date:   Sun Nov 30 12:17:21 2008 +0100
> >
> >    Bluetooth: Remove deprecated hci_usb driver
> >
> >    The old hci_usb driver has been fully replaced with the new btusb
> > driver
> >    and all major distributions switched to the new driver now. This
> > removes
> >    it since it should not be used at all anymore.
> >
> > so please confirm that btusb correctly supports that hardware?
>
> Thanks for the heads up! I'll compile the new sources and let you know
> if it's supported. However, since the hci_usb is being deprecated but
> not removed, shouldn't the patch be incorporated nonetheless?
>
> Luca
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
Seems to work fine on gentoo-sources-2.6.27-r5. Thank you all  :)
-- 
Markos Chandras

Re: [PATCH] bluetooth usb hci: ISSC usb dongle with buggy SCO support

[Luca Santarelli]

Il giorno 09/dic/08, alle ore 00:07, Luca Santarelli ha scritto:

>
> Il giorno 07/dic/08, alle ore 09:19, Andrew Morton ha scritto:
>
>> linux-next has:
>>
>> commit 12421b40b81d101d7535e03f1af197365adc932b
>> Author: Marcel Holtmann <marcel@holtmann.org>
>> Date:   Sun Nov 30 12:17:21 2008 +0100
>>
>>   Bluetooth: Remove deprecated hci_usb driver
>>
>>   The old hci_usb driver has been fully replaced with the new btusb  
>> driver
>>   and all major distributions switched to the new driver now. This  
>> removes
>>   it since it should not be used at all anymore.
>>
>> so please confirm that btusb correctly supports that hardware?
>
>
> Thanks for the heads up! I'll compile the new sources and let you  
> know if it's supported. However, since the hci_usb is being  
> deprecated but not removed, shouldn't the patch be incorporated  
> nonetheless?
>
> Luca

Ok, I'm back. I compiled the latest sources and the device is  
recognized and works with the new btusb driver. What about the  
deprecated driver? Will it be fixed or kept as it is?

Luca

Re: [PATCH] bluetooth usb hci: ISSC usb dongle with buggy SCO support

[Markos Chandras]

On Sunday 07 December 2008 10:19:53 Andrew Morton wrote:
> On Fri, 5 Dec 2008 00:02:13 +0100 Luca Santarelli 
<hrk@users.sourceforge.net> wrote:
> > From: Luca Santarelli <hrk <t> users.sourceforge.net>
> >
> > As reported at:
> > http://bugs.gentoo.org/show_bug.cgi?id=249523
> > and in reference of similar patches such as:
> > http://thread.gmane.org/gmane.linux.bluez.devel/15067
> >
> > This patch changes the blacklist entry for the ISSC bluetooth USB
> > dongle fixing the issue of the repeatedly appearing message
> >
> >   hci_scodata_packet: hci0 SCO packet for unknown connection handle 92
> >
> > in the kernel logs.
> >
> > Sighed-off-by: Luca Santarelli <hrk <at> users.sourceforge.net>
> > ---
> > This is my first kernel patch ever, I read the docs, but please notify
> > me if I made any mistake. Thank you all for your work, I'm happy to have
> > been able to contribute to this!
> >
> > The patch has been run against 2.6.27.7 and has been tested on three x86
> > machines, showing no issues. In my own tests, the dongle has been then
> > used to connect to devices and everything worked fine.
> >
> > --- linux-2.6.27.7/drivers/bluetooth/hci_usb.c.orig	2008-12-04
> > 20:18:38.000000000 +0100 +++
> > linux-2.6.27.7/drivers/bluetooth/hci_usb.c	2008-12-04 20:19:37.000000000
> > +0100 @@ -148,8 +148,8 @@ static struct usb_device_id blacklist_id
> >  	{ USB_DEVICE(0x047d, 0x105d), .driver_info = HCI_RESET },
> >  	{ USB_DEVICE(0x047d, 0x105e), .driver_info = HCI_RESET |
> > HCI_WRONG_SCO_MTU },
> >
> > -	/* ISSC Bluetooth Adapter v3.1 */
> > -	{ USB_DEVICE(0x1131, 0x1001), .driver_info = HCI_RESET },
> > +	/* ISSC Bluetooth Adapter v3.1 with buggy SCO support */
> > +	{ USB_DEVICE(0x1131, 0x1001), .driver_info = HCI_RESET |
> > HCI_BROKEN_ISOC },
> >
> >  	/* RTX Telecom based adapters with buggy SCO support */
> >  	{ USB_DEVICE(0x0400, 0x0807), .driver_info = HCI_BROKEN_ISOC },
>
> linux-next has:
>
> commit 12421b40b81d101d7535e03f1af197365adc932b
> Author: Marcel Holtmann <marcel@holtmann.org>
> Date:   Sun Nov 30 12:17:21 2008 +0100
>
>     Bluetooth: Remove deprecated hci_usb driver
>
>     The old hci_usb driver has been fully replaced with the new btusb
> driver and all major distributions switched to the new driver now. This
> removes it since it should not be used at all anymore.
>
> so please confirm that btusb correctly supports that hardware?
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
Unfortunatelly it doesnt work here. The new driver cant recognize my device. I 
am using gentoo-sources-2.6.26-r4 ( which means linux-sources-2.6.26-5).

I ll post again my device info from lsusb. I ll try to come up with a patch is 
possible

Bus 002 Device 002: ID 1131:1001 Integrated System Solution Corp. KY-BT100 
Bluetooth Adapter

Thanks
-- 
Markos Chandras