Re: [PATCH 2/2] kvm: use cpumask_var_t for cpus_hardware_enabled

Avi Kivity
2008-12-07T15:56:18Z

> This changes cpus_hardware_enabled from a cpumask_t to a cpumask_var_t:
> equivalent for CONFIG_CPUMASKS_OFFSTACK=n, otherwise dynamically allocated.
>
>
> -static cpumask_t cpus_hardware_enabled;
> +static cpumask_var_t cpus_hardware_enabled

This isn't on stack, so it isn't buying us anything.

Is the plan to drop cpumask_t? If so, we're penalizing non-stack users
by forcing them to go through another pointer (and cacheline).

--
error compiling committee.c: too many arguments to function