From: Li Zefan <lizf@cn.fujitsu.com>
To: Tim Blechmann <tim@klingt.org>
Cc: rostedt@goodmis.org, linux-rt-users@vger.kernel.org,
linux-kernel@vger.kernel.org,
Balbir Singh <balbir@linux.vnet.ibm.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH] [RT] avoid preemption in memory controller code
Date: Tue, 09 Dec 2008 09:13:12 +0800 [thread overview]
Message-ID: <493DC628.5060900@cn.fujitsu.com> (raw)
In-Reply-To: <1228746854-23875-1-git-send-email-tim@klingt.org>
CC: Balbir Singh <balbir@linux.vnet.ibm.com>
CC: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Tim Blechmann wrote:
> the lru_lock of struct mem_group_per_zone is used to avoid preemption
> during the __mem_cgroup_stat_add_safe function.
> therefore, a raw_spinlock_t should be used.
>
FYI, this lru_lock no longer exists in -mm tree. The following patch
removes that lock:
http://marc.info/?l=linux-mm&m=122665814801979&w=2
> Signed-off-by: Tim Blechmann <tim@klingt.org>
> ---
> mm/memcontrol.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 517f945..8661732 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -95,9 +95,9 @@ enum mem_cgroup_zstat_index {
>
> struct mem_cgroup_per_zone {
> /*
> - * spin_lock to protect the per cgroup LRU
> + * raw_spin_lock to protect the per cgroup LRU
> */
> - spinlock_t lru_lock;
> + raw_spinlock_t lru_lock;
> struct list_head active_list;
> struct list_head inactive_list;
> unsigned long count[NR_MEM_CGROUP_ZSTAT];
next prev parent reply other threads:[~2008-12-09 1:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-08 14:34 [PATCH] [RT] avoid preemption in memory controller code Tim Blechmann
2008-12-08 16:42 ` Steven Rostedt
2008-12-08 17:07 ` Tim Blechmann
2008-12-08 17:23 ` Steven Rostedt
2008-12-11 19:05 ` [PATCH] [RT] preempt_disable_rt for CONFIG_PREEMPT_RT Tim Blechmann
2008-12-09 1:13 ` Li Zefan [this message]
2008-12-09 1:32 ` [PATCH] [RT] avoid preemption in memory controller code KAMEZAWA Hiroyuki
[not found] <preempt_enable_rt();>
2008-12-11 19:00 ` Tim Blechmann
2008-12-12 1:17 ` KAMEZAWA Hiroyuki
2008-12-12 9:08 ` Tim Blechmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=493DC628.5060900@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tim@klingt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox