From: Gregory Haskins <ghaskins@novell.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git pull] RT scheduler updates for tip
Date: Tue, 09 Dec 2008 09:35:50 -0500 [thread overview]
Message-ID: <493E8246.1090309@novell.com> (raw)
In-Reply-To: <20081208161246.GB4570@elte.hu>
[-- Attachment #1: Type: text/plain, Size: 1664 bytes --]
Ingo Molnar wrote:
> okay, this series is quite bad so i'm disabling it for now. I sent a
> build fix earlier today, then i triggered this build failure:
>
> kernel/built-in.o: In function `dequeue_pushable_task':
> sched.c:(.text+0x4a9f): undefined reference to `plist_del'
> kernel/built-in.o: In function `enqueue_pushable_task':
> sched.c:(.text+0x5734): undefined reference to `plist_del'
> sched.c:(.text+0x5747): undefined reference to `plist_add'
>
> and then this:
>
> kernel/sched_rt.c: In function ‘next_prio’:
> kernel/sched_rt.c:574: error: ‘struct rq’ has no member named ‘cpu’
> kernel/sched_rt.c: In function ‘inc_rt_tasks’:
> kernel/sched_rt.c:619: error: ‘rq’ undeclared (first use in this function)
> kernel/sched_rt.c:619: error: (Each undeclared identifier is reported only once
> kernel/sched_rt.c:619: error: for each function it appears in.)
> kernel/sched_rt.c: In function ‘dec_rt_tasks’:
> kernel/sched_rt.c:667: error: ‘rq’ undeclared (first use in this function)
>
>
>
Hi Ingo,
I was able to reproduce your first error (in the previous mail) by
turning off CONFIG_SMP. I have folded your fix into my series and got
past it. However, I was not able to reproduce these two new errors. I
was thinking that perhaps something merged improperly between my (older)
tip/master and the merge point in cpus4096. So I rebased the series on
your latest tip/master as of this morning, but it still builds fine for
me. Could you send me the .config that causes this to blow up? I will
get it straightened out for you ASAP. Sorry for the inconvenience.
Thanks,
-Greg
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
next prev parent reply other threads:[~2008-12-09 14:32 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-05 14:24 [git pull] RT scheduler updates for tip Gregory Haskins
2008-12-08 14:32 ` Ingo Molnar
2008-12-08 16:05 ` [PATCH] sched: fix build failure in kernel/sched_rt.c Ingo Molnar
2008-12-08 16:14 ` Gregory Haskins
2008-12-08 16:12 ` [git pull] RT scheduler updates for tip Ingo Molnar
2008-12-08 16:57 ` Gregory Haskins
2008-12-09 14:35 ` Gregory Haskins [this message]
2008-12-12 11:34 ` Ingo Molnar
2008-12-12 11:49 ` Ingo Molnar
2008-12-29 15:37 ` Gregory Haskins
2008-12-29 18:13 ` Gregory Haskins
2009-01-11 4:01 ` Ingo Molnar
2009-01-11 9:53 ` Ingo Molnar
2009-01-12 14:45 ` Gregory Haskins
2009-01-12 14:45 ` Ingo Molnar
2009-01-12 15:05 ` Gregory Haskins
2009-01-12 19:23 ` [git pull] fixes for tip/sched/rt Gregory Haskins
2009-01-13 1:43 ` Ingo Molnar
2009-01-13 2:37 ` [PATCH v2] sched: fix build error in kernel/sched_rt.c when RT_GROUP_SCHED && !SMP Gregory Haskins
2009-01-14 8:01 ` Ingo Molnar
2009-01-14 10:54 ` Peter Zijlstra
2009-01-14 11:03 ` Ingo Molnar
2009-01-14 13:21 ` Gregory Haskins
2009-01-14 14:46 ` [PATCH v3 0/2] fixes for tip/sched/rt Gregory Haskins
2009-01-14 14:46 ` [PATCH v3 1/2] sched: de CPP-ify the scheduler code Gregory Haskins
2009-01-14 15:11 ` Steven Rostedt
2009-01-14 15:28 ` Gregory Haskins
2009-01-14 14:46 ` [PATCH v3 2/2] sched: fix build error in kernel/sched_rt.c when RT_GROUP_SCHED && !SMP Gregory Haskins
2009-01-15 12:30 ` [PATCH v3 0/2] fixes for tip/sched/rt Ingo Molnar
2009-01-16 13:35 ` Ingo Molnar
2009-01-16 13:45 ` Gregory Haskins
2009-01-16 13:46 ` Peter Zijlstra
2009-01-16 14:02 ` Gregory Haskins
2009-01-16 14:02 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=493E8246.1090309@novell.com \
--to=ghaskins@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox