From: Jeff Garzik <jeff@garzik.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
Jeff Garzik <jgarzik@redhat.com>,
Alexandru Romanescu <a_romanescu@yahoo.co.uk>,
Tejun Heo <tj@kernel.org>, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 2/2 v2] ATA: piix, fix pointer deref on suspend
Date: Tue, 09 Dec 2008 16:29:29 -0500 [thread overview]
Message-ID: <493EE339.1070806@garzik.org> (raw)
In-Reply-To: <1228855948-22886-2-git-send-email-jirislaby@gmail.com>
Jiri Slaby wrote:
> Commit
> ata_piix: add borked Tecra M4 to broken suspend list
> introduced DMI variables checking, but they can be null, so that
> we possibly dereference null.
>
> Check if they are null and avoid checks in that case.
>
> Solves:
> BUG: unable to handle kernel NULL pointer dereference at 0000000000000000
> IP: [<ffffffff8043da97>] piix_pci_device_suspend+0x117/0x230
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
> Cc: Jeff Garzik <jgarzik@redhat.com>
> Cc: Alexandru Romanescu <a_romanescu@yahoo.co.uk>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
> ---
> drivers/ata/ata_piix.c | 14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
Note that the original version of this patch went upstream last night...
next prev parent reply other threads:[~2008-12-09 21:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-03 8:13 [PATCH 1/1] ATA: piix, fix pointer deref on suspend Jiri Slaby
2008-12-03 9:04 ` Tejun Heo
2008-12-03 10:13 ` Alan Cox
2008-12-03 10:39 ` Tejun Heo
2008-12-09 5:47 ` Jeff Garzik
2008-12-09 20:52 ` [PATCH 1/2] DMI: add dmi_match Jiri Slaby
2008-12-09 20:52 ` [PATCH 2/2 v2] ATA: piix, fix pointer deref on suspend Jiri Slaby
2008-12-09 21:29 ` Jeff Garzik [this message]
2008-12-09 22:06 ` Jiri Slaby
2008-12-10 13:07 ` [PATCH 1/2] DMI: add dmi_match Jiri Slaby
2008-12-10 13:07 ` [PATCH 2/2] ATA: piix, cleanup dmi strings checking Jiri Slaby
2008-12-29 12:41 ` [PATCH 1/2] DMI: add dmi_match Jeff Garzik
2008-12-11 20:27 ` [PATCH 2/2 v2] ATA: piix, fix pointer deref on suspend Andrew Morton
2008-12-11 20:34 ` Jiri Slaby
2008-12-09 20:59 ` [PATCH 1/2] DMI: add dmi_match Alan Cox
2008-12-10 2:00 ` Tejun Heo
2008-12-11 20:29 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=493EE339.1070806@garzik.org \
--to=jeff@garzik.org \
--cc=a_romanescu@yahoo.co.uk \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@redhat.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox