From: Jiri Slaby <jirislaby@gmail.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] makesystem: revive cscope target
Date: Wed, 10 Dec 2008 13:46:51 +0100 [thread overview]
Message-ID: <493FBA3B.5010801@gmail.com> (raw)
In-Reply-To: <20081210124120.GA12784@uranus.ravnborg.org>
On 12/10/2008 01:41 PM, Sam Ravnborg wrote:
> On Wed, Dec 10, 2008 at 01:10:13PM +0100, Jiri Slaby wrote:
>> - export src and obj, so that we can check them in tags.sh
>> - don't allow * expansion during sh function calls
>
> What benefit does this patch give us?
> We do not use $obj neither $src in tags.sh.
I'm confused...
git kernel.org:/pub/scm/linux/kernel/git/sam/kbuild-next.git
says:
# Do not use full path is we do not use O=.. builds
if [ ${src} == ${obj} ]; then
tree=
else
tree=${srctree}
fi
in scripts/tags.sh.
> Likewise we do not pass it non-expanded parameters.
We do inside the script. Try to touch XYZ.S in your build tree, the tags.sh
won't work then.
next prev parent reply other threads:[~2008-12-10 12:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 12:10 [PATCH 1/1] makesystem: revive cscope target Jiri Slaby
2008-12-10 12:41 ` Sam Ravnborg
2008-12-10 12:46 ` Jiri Slaby [this message]
2008-12-10 13:00 ` Sam Ravnborg
2008-12-10 12:59 ` Jiri Slaby
2008-12-13 23:13 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=493FBA3B.5010801@gmail.com \
--to=jirislaby@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox