Re: [PATCH][RFC 23/23]: Support for zero-copy TCP transmit of user space data

Vladislav Bolkhovitin
2008-12-16T18:58:23Z

Christoph Hellwig wrote:
> If you don't believe that increasing struct page size for a fringe
> feature is a no-go submit the patch to the VM people and wait..

I guessed, it can be no-go, this is why I wrote that this feature isn't
required for iSCSI-SCST functionality. But, since the implementation is
*so* simple and doesn't do any layering violation, I have a hope that
once it disabled by default it will be harmless and, hence, could be
accepted. Only few people need this feature. Otherwise there will be an
alternative for them between enable that feature, then recompile, vs
patch the kernel, enable that feature, then recompile.

When I was developing it my main goal was to do it as simple as
possible. I believe, I succeeded in it. If it's rejected, it will simply
live out of tree until me or somebody else finds time to reimplement it
in an acceptable, although at least 10 times more complicated manner.

Thanks, I'll follow your advise.

Vlad