From: Li Zefan <lizf@cn.fujitsu.com>
To: menage@google.com
Cc: kamezawa.hiroyu@jp.fujitsu.com, balbir@linux.vnet.ibm.com,
containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [RFC][PATCH 1/3] CGroups: Add a per-subsystem hierarchy_mutex
Date: Thu, 11 Dec 2008 11:05:14 +0800 [thread overview]
Message-ID: <4940836A.9010502@cn.fujitsu.com> (raw)
In-Reply-To: <20081210234432.065445000@menage.corp.google.com>
> +static void cgroup_lock_hierarchy(struct cgroupfs_root *root)
> +{
> + /* We need to take each hierarchy_mutex in a consistent order */
This comment is not so clear. Do you mean for_each_subsys() can't be
used here?
But this function is used in cgroup.c internally, and always called
with cgroup_lock held, so it's OK to use for_each_subsys().
> + int i;
> +
> + for (i = 0; i < CGROUP_SUBSYS_COUNT; i++) {
> + struct cgroup_subsys *ss = subsys[i];
> + if (ss->root == root)
> + mutex_lock_nested(&ss->hierarchy_mutex, i);
> + }
> +}
next prev parent reply other threads:[~2008-12-11 3:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 23:36 [RFC][PATCH 0/3] CGroups: CGroups: Hierarchy locking/refcount changes menage
2008-12-10 23:36 ` [RFC][PATCH 1/3] CGroups: Add a per-subsystem hierarchy_mutex menage
2008-12-11 0:37 ` KAMEZAWA Hiroyuki
2008-12-11 0:44 ` Paul Menage
2008-12-11 6:30 ` Balbir Singh
2008-12-11 3:05 ` Li Zefan [this message]
2008-12-11 17:07 ` Paul Menage
2008-12-11 6:29 ` Balbir Singh
2008-12-11 17:09 ` Paul Menage
2008-12-10 23:36 ` [RFC][PATCH 2/3] CGroups: Use hierarchy_mutex in memory controller menage
2008-12-11 0:49 ` KAMEZAWA Hiroyuki
2008-12-11 0:52 ` Paul Menage
2008-12-11 1:05 ` KAMEZAWA Hiroyuki
2008-12-11 6:33 ` Balbir Singh
2008-12-11 6:47 ` Li Zefan
2008-12-11 6:53 ` KAMEZAWA Hiroyuki
2008-12-11 17:05 ` Paul Menage
2008-12-12 1:12 ` KAMEZAWA Hiroyuki
2008-12-10 23:36 ` [RFC][PATCH 3/3] CGroups: Add css_tryget() menage
2008-12-11 0:52 ` KAMEZAWA Hiroyuki
2008-12-11 7:02 ` [RFC][PATCH]example: use css_tryget() in memcg " KAMEZAWA Hiroyuki
2008-12-11 5:15 ` KAMEZAWA Hiroyuki
2008-12-11 7:28 ` Paul Menage
2008-12-11 7:29 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4940836A.9010502@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=containers@lists.linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox