* [PATCH 1/2] tracing/fastboot: fix len of func buffer
@ 2008-12-11 15:10 Frederic Weisbecker
2008-12-12 9:00 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Frederic Weisbecker @ 2008-12-11 15:10 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Stephen Rothwell, Linux Kernel
From: Stephen Rothwell <sfr@canb.auug.org.au>
Impact: fix possible stack overrun
This is a port of a patch included in the mainline (KSYM_SYMBOL_LEN fixes).
The current func len is not large enough to contain the max symbol len, the
right size must be KSYM_SYMBOL_LEN.
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
diff --git a/include/trace/boot.h b/include/trace/boot.h
index 6b54537..3ec58b4 100644
--- a/include/trace/boot.h
+++ b/include/trace/boot.h
@@ -9,7 +9,7 @@
*/
struct boot_trace_call {
pid_t caller;
- char func[KSYM_NAME_LEN];
+ char func[KSYM_SYMBOL_LEN];
};
/*
@@ -17,7 +17,7 @@ struct boot_trace_call {
* while it returns.
*/
struct boot_trace_ret {
- char func[KSYM_NAME_LEN];
+ char func[KSYM_SYMBOL_LEN];
int result;
unsigned long long duration; /* nsecs */
};
--
1.6.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] tracing/fastboot: fix len of func buffer
2008-12-11 15:10 [PATCH 1/2] tracing/fastboot: fix len of func buffer Frederic Weisbecker
@ 2008-12-12 9:00 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-12-12 9:00 UTC (permalink / raw)
To: Frederic Weisbecker; +Cc: Stephen Rothwell, Linux Kernel
* Frederic Weisbecker <fweisbec@gmail.com> wrote:
> From: Stephen Rothwell <sfr@canb.auug.org.au>
>
> Impact: fix possible stack overrun
>
> This is a port of a patch included in the mainline (KSYM_SYMBOL_LEN fixes).
> The current func len is not large enough to contain the max symbol len, the
> right size must be KSYM_SYMBOL_LEN.
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
thanks Frederic and Stephen, applied to tip/tracing/fastboot.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-12 9:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-11 15:10 [PATCH 1/2] tracing/fastboot: fix len of func buffer Frederic Weisbecker
2008-12-12 9:00 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox