From: Hannes Eder <hannes@hanneseder.net>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Karsten Keil <kkeil@suse.de>
Cc: linux-kernel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org
Subject: Re: [PATCHv2 4/9] mISDN: fix sparse warning
Date: Wed, 10 Dec 2008 20:41:55 +0100 [thread overview]
Message-ID: <49417296.25e2660a.2824.ffffc60b@mx.google.com> (raw)
In-Reply-To: <49403C26.5050402@gmail.com>
Impact: un-export symbol 'plx_lock'
Fix this warning:
drivers/isdn/hardware/mISDN/hfcmulti.c:176:1: warning: symbol 'plx_lock' shadows an earlier one
drivers/isdn/hardware/mISDN/hfcmulti.c:175:19: originally declared here
Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
On Wed, Dec 10, 2008 at 11:01 PM, Jiri Slaby <jirislaby@gmail.com> wrote:
> On 12/10/2008 04:13 PM, Hannes Eder wrote:
>> Should 'plx_lock' be declared in a header file? Or is it really
>> neccessart to export it?
>
> As there is no other user, I vote for unexporting it.
In that case patch number 4 looks like this:
drivers/isdn/hardware/mISDN/hfcmulti.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/isdn/hardware/mISDN/hfcmulti.c b/drivers/isdn/hardware/mISDN/hfcmulti.c
index 599d832..970201d 100644
--- a/drivers/isdn/hardware/mISDN/hfcmulti.c
+++ b/drivers/isdn/hardware/mISDN/hfcmulti.c
@@ -173,7 +173,6 @@ static int interrupt_registered;
static struct hfc_multi *syncmaster;
static int plxsd_master; /* if we have a master card (yet) */
static spinlock_t plx_lock; /* may not acquire other lock inside */
-EXPORT_SYMBOL(plx_lock);
#define TYP_E1 1
#define TYP_4S 4
--
1.5.6.3
prev parent reply other threads:[~2008-12-11 20:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 15:13 [PATCH 4/9] mISDN: fix sparse warnings Hannes Eder
2008-12-10 22:01 ` Jiri Slaby
2008-12-10 19:41 ` Hannes Eder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49417296.25e2660a.2824.ffffc60b@mx.google.com \
--to=hannes@hanneseder.net \
--cc=jirislaby@gmail.com \
--cc=kkeil@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox