From: Eric Dumazet <dada1@cosmosbay.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Christoph Hellwig <hch@infradead.org>,
David Miller <davem@davemloft.net>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
linux-kernel@vger.kernel.org,
"kernel-testers@vger.kernel.org >> Kernel Testers List"
<kernel-testers@vger.kernel.org>, Mike Galbraith <efault@gmx.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Linux Netdev List <netdev@vger.kernel.org>,
Christoph Lameter <cl@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, Al Viro <viro@ZenIV.linux.org.uk>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: [PATCH v3 3/7] fs: Introduce a per_cpu last_ino allocator
Date: Thu, 11 Dec 2008 23:39:18 +0100 [thread overview]
Message-ID: <49419696.9080509@cosmosbay.com> (raw)
In-Reply-To: <493100B0.6090104@cosmosbay.com>
new_inode() dirties a contended cache line to get increasing
inode numbers.
Solve this problem by providing to each cpu a per_cpu variable,
feeded by the shared last_ino, but once every 1024 allocations.
This reduce contention on the shared last_ino, and give same
spreading ino numbers than before.
(same wraparound after 2^32 allocations)
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
---
fs/inode.c | 35 ++++++++++++++++++++++++++++++++---
1 files changed, 32 insertions(+), 3 deletions(-)
diff --git a/fs/inode.c b/fs/inode.c
index f94f889..dc8e72a 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -556,6 +556,36 @@ repeat:
return node ? inode : NULL;
}
+#ifdef CONFIG_SMP
+/*
+ * Each cpu owns a range of 1024 numbers.
+ * 'shared_last_ino' is dirtied only once out of 1024 allocations,
+ * to renew the exhausted range.
+ */
+static DEFINE_PER_CPU(int, last_ino);
+
+static int last_ino_get(void)
+{
+ static atomic_t shared_last_ino;
+ int *p = &get_cpu_var(last_ino);
+ int res = *p;
+
+ if (unlikely((res & 1023) == 0))
+ res = atomic_add_return(1024, &shared_last_ino) - 1024;
+
+ *p = ++res;
+ put_cpu_var(last_ino);
+ return res;
+}
+#else
+static int last_ino_get(void)
+{
+ static int last_ino;
+
+ return ++last_ino;
+}
+#endif
+
/**
* new_inode - obtain an inode
* @sb: superblock
@@ -575,7 +605,6 @@ struct inode *new_inode(struct super_block *sb)
* error if st_ino won't fit in target struct field. Use 32bit counter
* here to attempt to avoid that.
*/
- static unsigned int last_ino;
struct inode * inode;
spin_lock_prefetch(&inode_lock);
@@ -583,11 +612,11 @@ struct inode *new_inode(struct super_block *sb)
inode = alloc_inode(sb);
if (inode) {
percpu_counter_inc(&nr_inodes);
+ inode->i_state = 0;
+ inode->i_ino = last_ino_get();
spin_lock(&inode_lock);
list_add(&inode->i_list, &inode_in_use);
list_add(&inode->i_sb_list, &sb->s_inodes);
- inode->i_ino = ++last_ino;
- inode->i_state = 0;
spin_unlock(&inode_lock);
}
return inode;
next prev parent reply other threads:[~2008-12-11 22:41 UTC|newest]
Thread overview: 185+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-16 17:38 2.6.28-rc5: Reported regressions 2.6.26 -> 2.6.27 Rafael J. Wysocki
2008-11-16 17:38 ` [Bug #11207] VolanoMark regression with 2.6.27-rc1 Rafael J. Wysocki
2008-11-16 17:40 ` [Bug #11215] INFO: possible recursive locking detected ps2_command Rafael J. Wysocki
2008-11-16 17:40 ` [Bug #11308] tbench regression on each kernel release from 2.6.22 -> 2.6.28 Rafael J. Wysocki
2008-11-17 9:06 ` Ingo Molnar
2008-11-17 9:14 ` David Miller
2008-11-17 11:01 ` Ingo Molnar
2008-11-17 11:20 ` Eric Dumazet
2008-11-17 16:11 ` Ingo Molnar
2008-11-17 16:35 ` Eric Dumazet
2008-11-17 17:08 ` Ingo Molnar
2008-11-17 17:25 ` Ingo Molnar
2008-11-17 17:33 ` Eric Dumazet
2008-11-17 17:38 ` Linus Torvalds
2008-11-17 17:42 ` Eric Dumazet
2008-11-17 18:23 ` Ingo Molnar
2008-11-17 18:33 ` Linus Torvalds
2008-11-17 18:49 ` Ingo Molnar
2008-11-17 19:30 ` Eric Dumazet
2008-11-17 19:39 ` David Miller
2008-11-17 19:43 ` Eric Dumazet
2008-11-17 19:55 ` Linus Torvalds
2008-11-17 20:16 ` David Miller
2008-11-17 20:30 ` Linus Torvalds
2008-11-17 20:58 ` David Miller
2008-11-18 9:44 ` Nick Piggin
2008-11-18 15:58 ` Linus Torvalds
2008-11-19 4:31 ` Nick Piggin
2008-11-20 9:14 ` David Miller
2008-11-20 9:06 ` David Miller
2008-11-18 12:29 ` Mike Galbraith
2008-11-17 19:57 ` Ingo Molnar
2008-11-17 20:20 ` (avc_has_perm_noaudit()) " Ingo Molnar
2008-11-17 20:32 ` ip_queue_xmit(): " Ingo Molnar
2008-11-17 20:57 ` Eric Dumazet
2008-11-18 9:12 ` Nick Piggin
2008-11-17 20:47 ` Ingo Molnar
2008-11-17 20:56 ` Eric Dumazet
2008-11-17 20:55 ` skb_release_head_state(): " Ingo Molnar
2008-11-17 21:01 ` David Miller
2008-11-17 21:04 ` Eric Dumazet
2008-11-17 21:34 ` Linus Torvalds
2008-11-17 21:38 ` Ingo Molnar
2008-11-17 21:09 ` tcp_ack(): " Ingo Molnar
2008-11-17 21:19 ` tcp_recvmsg(): " Ingo Molnar
2008-11-17 21:26 ` eth_type_trans(): " Ingo Molnar
2008-11-17 21:40 ` Eric Dumazet
2008-11-17 23:41 ` Eric Dumazet
2008-11-18 0:01 ` Linus Torvalds
2008-11-18 8:35 ` Eric Dumazet
2008-11-17 21:52 ` Linus Torvalds
2008-11-18 5:16 ` David Miller
2008-11-18 5:35 ` Eric Dumazet
2008-11-18 7:00 ` David Miller
2008-11-18 8:30 ` Ingo Molnar
2008-11-18 8:49 ` Eric Dumazet
2008-11-17 21:35 ` __inet_lookup_established(): " Ingo Molnar
2008-11-17 22:14 ` Eric Dumazet
2008-11-17 21:59 ` system_call() - " Ingo Molnar
2008-11-17 22:09 ` Linus Torvalds
2008-11-17 22:08 ` Ingo Molnar
2008-11-17 22:15 ` Eric Dumazet
2008-11-17 22:26 ` Ingo Molnar
2008-11-17 22:39 ` Eric Dumazet
2008-11-18 5:23 ` David Miller
2008-11-18 8:45 ` Ingo Molnar
2008-11-17 22:14 ` tcp_transmit_skb() - " Ingo Molnar
2008-11-17 22:19 ` Ingo Molnar
2008-11-17 19:36 ` David Miller
2008-11-17 19:31 ` David Miller
2008-11-17 19:47 ` Linus Torvalds
2008-11-17 19:51 ` David Miller
2008-11-17 19:53 ` Ingo Molnar
2008-11-17 22:47 ` Ingo Molnar
2008-11-17 19:21 ` David Miller
2008-11-17 19:48 ` Linus Torvalds
2008-11-17 19:52 ` David Miller
2008-11-17 19:57 ` Linus Torvalds
2008-11-17 20:18 ` David Miller
2008-11-19 19:43 ` Christoph Lameter
2008-11-19 20:14 ` Ingo Molnar
2008-11-20 23:52 ` Christoph Lameter
2008-11-21 8:30 ` Ingo Molnar
2008-11-21 8:51 ` Eric Dumazet
2008-11-21 9:05 ` David Miller
2008-11-21 12:51 ` Eric Dumazet
2008-11-21 15:13 ` [PATCH] fs: pipe/sockets/anon dentries should not have a parent Eric Dumazet
2008-11-21 15:21 ` Ingo Molnar
2008-11-21 15:28 ` Eric Dumazet
2008-11-21 15:34 ` Ingo Molnar
2008-11-26 23:27 ` [PATCH 0/6] fs: Scalability of sockets/pipes allocation/deallocation on SMP Eric Dumazet
2008-11-27 1:37 ` Christoph Lameter
2008-11-27 6:27 ` Eric Dumazet
2008-11-27 14:44 ` Christoph Lameter
2008-11-27 9:39 ` Christoph Hellwig
2008-11-28 18:03 ` Ingo Molnar
2008-11-28 18:47 ` Peter Zijlstra
2008-11-29 6:38 ` Christoph Hellwig
2008-11-29 8:07 ` Eric Dumazet
2008-11-29 8:43 ` [PATCH v2 0/5] " Eric Dumazet
2008-12-11 22:38 ` [PATCH v3 0/7] " Eric Dumazet
2008-12-11 22:38 ` [PATCH v3 1/7] fs: Use a percpu_counter to track nr_dentry Eric Dumazet
2007-07-24 1:24 ` Nick Piggin
2008-12-16 21:04 ` Paul E. McKenney
2008-12-11 22:39 ` [PATCH v3 2/7] fs: Use a percpu_counter to track nr_inodes Eric Dumazet
2007-07-24 1:30 ` Nick Piggin
2008-12-12 5:11 ` Eric Dumazet
2008-12-16 21:10 ` Paul E. McKenney
2008-12-11 22:39 ` Eric Dumazet [this message]
2007-07-24 1:34 ` [PATCH v3 3/7] fs: Introduce a per_cpu last_ino allocator Nick Piggin
2008-12-16 21:26 ` Paul E. McKenney
2008-12-11 22:39 ` [PATCH v3 4/7] fs: Introduce SINGLE dentries for pipes, socket, anon fd Eric Dumazet
2008-12-16 21:40 ` Paul E. McKenney
2008-12-11 22:40 ` [PATCH v3 5/7] fs: new_inode_single() and iput_single() Eric Dumazet
2008-12-16 21:41 ` Paul E. McKenney
2008-12-11 22:40 ` [PATCH v3 6/7] fs: struct file move from call_rcu() to SLAB_DESTROY_BY_RCU Eric Dumazet
2007-07-24 1:13 ` Nick Piggin
2008-12-12 2:50 ` Nick Piggin
2008-12-12 4:45 ` Eric Dumazet
2008-12-12 16:48 ` Eric Dumazet
2008-12-13 2:07 ` Christoph Lameter
2008-12-17 20:25 ` Eric Dumazet
2008-12-13 1:41 ` Christoph Lameter
2008-12-11 22:41 ` [PATCH v3 7/7] fs: MS_NOREFCOUNT Eric Dumazet
2008-11-29 8:43 ` [PATCH v2 1/5] fs: Use a percpu_counter to track nr_dentry Eric Dumazet
2008-11-29 8:43 ` [PATCH v2 2/5] fs: Use a percpu_counter to track nr_inodes Eric Dumazet
2008-11-29 8:44 ` [PATCH v2 3/5] fs: Introduce a per_cpu last_ino allocator Eric Dumazet
2008-11-29 8:44 ` [PATCH v2 4/5] fs: Introduce SINGLE dentries for pipes, socket, anon fd Eric Dumazet
2008-11-29 10:38 ` Jörn Engel
2008-11-29 11:14 ` Eric Dumazet
2008-11-29 8:45 ` [PATCH v2 5/5] fs: new_inode_single() and iput_single() Eric Dumazet
2008-11-29 11:14 ` Jörn Engel
2008-11-26 23:30 ` [PATCH 1/6] fs: Introduce a per_cpu nr_dentry Eric Dumazet
2008-11-27 9:41 ` Christoph Hellwig
2008-11-26 23:32 ` [PATCH 3/6] fs: Introduce a per_cpu last_ino allocator Eric Dumazet
2008-11-27 9:46 ` Christoph Hellwig
2008-11-26 23:32 ` [PATCH 4/6] fs: Introduce a per_cpu nr_inodes Eric Dumazet
2008-11-27 9:32 ` Peter Zijlstra
2008-11-27 9:39 ` Peter Zijlstra
2008-11-27 9:48 ` Christoph Hellwig
2008-11-27 10:01 ` Eric Dumazet
2008-11-27 10:07 ` Andi Kleen
2008-11-27 14:46 ` Christoph Lameter
2008-11-26 23:32 ` [PATCH 5/6] fs: Introduce special inodes Eric Dumazet
2008-11-27 8:20 ` David Miller
2008-11-26 23:32 ` [PATCH 6/6] fs: Introduce kern_mount_special() to mount special vfs Eric Dumazet
2008-11-27 8:21 ` David Miller
2008-11-27 9:53 ` Christoph Hellwig
2008-11-27 10:04 ` Eric Dumazet
2008-11-27 10:10 ` Christoph Hellwig
2008-11-28 9:26 ` Al Viro
2008-11-28 9:34 ` Al Viro
2008-11-28 18:02 ` Ingo Molnar
2008-11-28 18:58 ` Ingo Molnar
2008-11-28 22:20 ` Eric Dumazet
2008-11-28 22:37 ` Eric Dumazet
2008-11-28 22:43 ` Eric Dumazet
2008-11-21 15:36 ` [PATCH] fs: pipe/sockets/anon dentries should not have a parent Christoph Hellwig
2008-11-21 17:58 ` [PATCH] fs: pipe/sockets/anon dentries should have themselves as parent Eric Dumazet
2008-11-21 18:43 ` Matthew Wilcox
2008-11-23 3:53 ` Eric Dumazet
2008-11-21 9:18 ` [Bug #11308] tbench regression on each kernel release from 2.6.22 -> 2.6.28 Ingo Molnar
2008-11-21 9:03 ` David Miller
2008-11-21 16:11 ` Christoph Lameter
2008-11-21 18:06 ` Christoph Lameter
2008-11-21 18:16 ` Eric Dumazet
2008-11-21 18:19 ` Eric Dumazet
2008-11-16 17:40 ` [Bug #11543] kernel panic: softlockup in tick_periodic() ??? Rafael J. Wysocki
2008-11-16 17:40 ` [Bug #11404] BUG: in 2.6.23-rc3-git7 in do_cciss_intr Rafael J. Wysocki
2008-11-17 16:19 ` Randy Dunlap
2008-11-16 17:40 ` [Bug #11664] acpi errors and random freeze on sony vaio sr Rafael J. Wysocki
2008-11-16 17:40 ` [Bug #11569] Panic stop CPUs regression Rafael J. Wysocki
2008-11-16 17:40 ` [Bug #11698] 2.6.27-rc7, freezes with > 1 s2ram cycle Rafael J. Wysocki
2008-11-16 17:40 ` [Bug #11795] ks959-sir dongle no longer works under 2.6.27 (REGRESSION) Rafael J. Wysocki
2008-11-16 17:40 ` [Bug #11836] Scheduler on C2D CPU and latest 2.6.27 kernel Rafael J. Wysocki
2008-11-16 17:40 ` [Bug #11805] mounting XFS produces a segfault Rafael J. Wysocki
2008-11-17 14:44 ` Christoph Hellwig
2008-11-16 17:40 ` [Bug #11876] RCU hang on cpu re-hotplug with 2.6.27rc8 Rafael J. Wysocki
2008-11-16 17:40 ` [Bug #11865] WOL for E100 Doesn't Work Anymore Rafael J. Wysocki
2008-11-16 17:40 ` [Bug #11886] without serial console system doesn't poweroff Rafael J. Wysocki
2008-11-16 17:40 ` [Bug #11843] usb hdd problems with 2.6.27.2 Rafael J. Wysocki
2008-11-16 21:37 ` Luciano Rocha
2008-11-16 17:41 ` [Bug #11983] iwlagn: wrong command queue 31, command id 0x0 Rafael J. Wysocki
2008-11-16 17:41 ` [Bug #12039] Regression: USB/DVB 2.6.26.8 --> 2.6.27.6 Rafael J. Wysocki
2008-11-16 17:41 ` [Bug #12048] Regression in bonding between 2.6.26.8 and 2.6.27.6 Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49419696.9080509@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=efault@gmx.de \
--cc=hch@infradead.org \
--cc=kernel-testers@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rjw@sisk.pl \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox