public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Arnold <Matthew.Arnold-1@uts.edu.au>
To: greg@kroah.com
Cc: bugme-daemon@bugzilla.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] Re: [Bug 12212] add 5372:2303 to /drivers/usb/serial/pl2303
Date: Sat, 13 Dec 2008 22:42:53 +1100	[thread overview]
Message-ID: <49439FBD.20504@uts.edu.au> (raw)
In-Reply-To: <20081213085654.5CBFB108040@picon.linux-foundation.org>

bugme-daemon@bugzilla.kernel.org wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=12212
>
>
>
>
>
> ------- Comment #1 from greg@kroah.com  2008-12-13 00:56 -------
> On Sat, Dec 13, 2008 at 12:29:04AM -0800, bugme-daemon@bugzilla.kernel.org
> wrote:
>   
>> Problem: an unbranded USB-serial converter is not detected
>> Steps taken to resolve the problem: 
>> (unsuccessful) force usb-serial detection by adding (Debian?) udev rules -
>> detects device but incorrectly defaults to generic which doesn't work
>> (successful) added vendor:product to pl2303 / recompile / insert module
>>     
>
> Can you send me the patch that you made, in the format described in
> Documentation/SubmittingPatches, through email, and I will be able to
> apply it and give you the proper credit.
>
>
>   
ok, I'm not at all familiar with kernel development but here's my 
contribution.
I got the idea from:
http://www.linuxquestions.org/questions/linux-hardware-18/obscure-usb-serial-adapter-368278/

This patch adds the "Superial" USB-Serial converter to pl2303 so that it 
is detected, by the correct driver.
Adds the relevant vendor:product (5372:2303) to the device tables in 
pl2303.c & pl2303.h.
The patch has been tested against 2.6.24-22-generic.

Signed-off-by: Matthew D Arnold <matthew.arnold-1[AT]uts.edu[DOT]au>


------------------------------------------------------------------------------------------
diff -uprN -X ./linux-source-2.6.24-vanilla/Documentation/dontdiff 
./linux-sourc
e-2.6.24-vanilla/drivers/usb/serial/pl2303.c 
./linux-source-2.6.24-patched/drive
rs/usb/serial/pl2303.c
--- ./linux-source-2.6.24-vanilla/drivers/usb/serial/pl2303.c    
2008-11-25 04:46
:05.000000000 +1100
+++ ./linux-source-2.6.24-patched/drivers/usb/serial/pl2303.c    
2008-12-13 21:52
:36.000000000 +1100
@@ -90,6 +90,7 @@ static struct usb_device_id id_table []
     { USB_DEVICE(HL340_VENDOR_ID, HL340_PRODUCT_ID) },
     { USB_DEVICE(YCCABLE_VENDOR_ID, YCCABLE_PRODUCT_ID) },
     { USB_DEVICE(SANWA_VENDOR_ID, SANWA_PRODUCT_ID) },
+    { USB_DEVICE(SUPERIAL_VENDOR_ID, SUPERIAL_PRODUCT_ID) },
     { }                    /* Terminating entry */
 };
 
diff -uprN -X ./linux-source-2.6.24-vanilla/Documentation/dontdiff 
./linux-sourc
e-2.6.24-vanilla/drivers/usb/serial/pl2303.h 
./linux-source-2.6.24-patched/drive
rs/usb/serial/pl2303.h
--- ./linux-source-2.6.24-vanilla/drivers/usb/serial/pl2303.h    
2008-11-25 04:46
:05.000000000 +1100
+++ ./linux-source-2.6.24-patched/drivers/usb/serial/pl2303.h    
2008-12-13 21:52
:09.000000000 +1100
@@ -116,3 +116,8 @@
 /* Sanwa KB-USB2 multimeter cable (ID: 11ad:0001) */
 #define SANWA_VENDOR_ID        0x11ad
 #define SANWA_PRODUCT_ID    0x0001
+
+/* "Superial" USB - Serial */
+#define SUPERIAL_VENDOR_ID    0x5372
+#define SUPERIAL_PRODUCT_ID    0x2303
+


           reply	other threads:[~2008-12-13 11:43 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20081213085654.5CBFB108040@picon.linux-foundation.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49439FBD.20504@uts.edu.au \
    --to=matthew.arnold-1@uts.edu.au \
    --cc=bugme-daemon@bugzilla.kernel.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox