From: Reinhard Nissl <rnissl@gmx.de>
To: linux-kernel@vger.kernel.org
Cc: greg@kroah.com
Subject: PATCH: mvsas: increase port type detection delay to suit Seagate's 15k6 drive ST3450856SS 0003
Date: Sun, 14 Dec 2008 23:50:04 +0100 [thread overview]
Message-ID: <49458D9C.5080906@gmx.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 1343 bytes --]
Hi Greg,
I hope you don't mind following your suggestion:
> Also, please cc: the stable developers if you want them to pay attention
> to messages like this.
-------- Original-Nachricht --------
Betreff: Re: PATCH: mvsas: increase port type detection delay to
suit Seagate's 15k6 drive ST3450856SS 0003
Datum: Fri, 12 Dec 2008 21:23:45 +0100
Von: Reinhard Nissl <rnissl@gmx.de>
An: linux-scsi@vger.kernel.org
CC: Ke Wei <kewei@marvell.com>, Jeff Garzik
<jgarzik@redhat.com>, James Bottomley
<James.Bottomley@hansenpartnership.com>
Referenzen: <493BC76F.3060105@gmx.de> <49405137.9000902@gmx.de>
Hi,
I wonder why no one has dropped me a line so far. I hope you
don't mind CCing you directly. I found your email addresses on
mailing list entries regarding mvsas. I attach the little patch
again for ease of use.
Reinhard Nissl schrieb:
> I increased the delay step by step until loading of mvsas
> reliably detected the drive 200 times in sequence. A much better
> approach would be to monitor the hardware for some flag which
> indicates that port detection has finished, but I do not have any
> hardware documentation.
>
> BTW: patch is against
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.27.y.git
>
> Signed-off-by: Reinhard Nissl <rnissl@gmx.de>
Bye.
--
Dipl.-Inform. (FH) Reinhard Nissl
mailto:rnissl@gmx.de
[-- Attachment #2: mvsas.diff --]
[-- Type: text/x-patch, Size: 451 bytes --]
diff --git a/drivers/scsi/mvsas.c b/drivers/scsi/mvsas.c
index 1dd70d7..23e5a87 100644
--- a/drivers/scsi/mvsas.c
+++ b/drivers/scsi/mvsas.c
@@ -2959,7 +2959,7 @@ static int __devinit mvs_hw_init(struct mvs_info *mvi)
/* enable auto port detection */
mw32(GBL_PORT_TYPE, MODE_AUTO_DET_EN);
- msleep(100);
+ msleep(1100);
/* init and reset phys */
for (i = 0; i < mvi->chip->n_phy; i++) {
u32 lo = be32_to_cpu(*(u32 *)&mvi->sas_addr[4]);
next reply other threads:[~2008-12-14 22:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-14 22:50 Reinhard Nissl [this message]
2008-12-15 0:04 ` PATCH: mvsas: increase port type detection delay to suit Seagate's 15k6 drive ST3450856SS 0003 Greg KH
2008-12-21 19:11 ` Reinhard Nissl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49458D9C.5080906@gmx.de \
--to=rnissl@gmx.de \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox