* [PATCH] ring_buffer: remove unused ring_buffer size
@ 2008-12-17 9:48 Lai Jiangshan
2008-12-18 12:50 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Lai Jiangshan @ 2008-12-17 9:48 UTC (permalink / raw)
To: Steven Rostedt, Ingo Molnar, Linux Kernel Mailing List
struct ring_buffer.size is not set after ring_buffer is initialized
or resized. it is always 0.
we can use "buffer->pages * BUF_PAGE_SIZE" to get ring_buffer's size
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
---
diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index 668bbb5..7c7ec06 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -202,7 +202,6 @@ struct ring_buffer_per_cpu {
};
struct ring_buffer {
- unsigned long size;
unsigned pages;
unsigned flags;
int cpus;
@@ -2090,8 +2089,7 @@ int ring_buffer_swap_cpu(struct ring_buffer *buffer_a,
return -EINVAL;
/* At least make sure the two buffers are somewhat the same */
- if (buffer_a->size != buffer_b->size ||
- buffer_a->pages != buffer_b->pages)
+ if (buffer_a->pages != buffer_b->pages)
return -EINVAL;
cpu_buffer_a = buffer_a->buffers[cpu];
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-18 12:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-17 9:48 [PATCH] ring_buffer: remove unused ring_buffer size Lai Jiangshan
2008-12-18 12:50 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox