Re: [BUG] cdev_put() race condition

Greg KH
2008-12-17T19:59:23Z

On Wed, Dec 17, 2008 at 08:39:03PM +0100, Hans Verkuil wrote:
> On Wednesday 17 December 2008 20:30:32 Hans Verkuil wrote:
> >
> > This solves this particular problem. But this will certainly break v4l as
> > it is right now, since the spin_lock means that the kref's release cannot
> > do any sleeps, which is possible in v4l. If we want to allow that in
> > cdev, then the spinlock has to be replaced by a mutex. But I have the
> > strong feeling that that's not going to happen :-)
>
> Note that if we ever allow drivers to hook in their own release callback,
> then we certainly should switch to a mutex in the cdev struct, rather than
> a global mutex. It obviously makes life more complicated for cdev, but much
> easier for drivers.

I don't see it being easier for drivers, you should provide this kind of
infrastructure within your framework already.

Actually, we already do provide this kind of framework, what's wrong
with using "struct device" for this, like the rest of the kernel does?
That is the device you need to be doing the reference counting and
release code for, it is exactly what it is there for.

So why is V4L different than the rest of the kernel in that it wishes to
do things differently?

confused,

greg k-h