Re: [PATCH 5/9] exofs: dir_inode and directory operations

Boaz Harrosh
2008-12-31T15:34:22Z

Andrew Morton wrote:
> On Tue, 16 Dec 2008 17:28:57 +0200
> Boaz Harrosh <bharrosh@panasas.com> wrote:
>
>> implementation of directory and inode operations.
>>
>> * A directory is treated as a file, and essentially contains a list
>> of <file name, inode #> pairs for files that are found in that
>> directory. The object IDs correspond to the files' inode numbers
>> and are allocated using a 64bit incrementing global counter.
>> * Each file's control block (AKA on-disk inode) is stored in its
>> object's attributes. This applies to both regular files and other
>> types (directories, device files, symlinks, etc.).
>>
>> ...
>>
>> fs/exofs/dir.c | 649 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>
> yes, this does look rather ext2-like ;)
>
> How long ago was the code cloned from ext2? iirc there have been a
> number of fairly subtle bugs fixed in ext2/dir.c over the past year or
> three. If the code was not quite recently cloned then I'd suggest that
> you spend a bit of time looking through the ext2 changelogs, see if
> there are any bugfixes which needs to be ported.
>
>

Long! Like Linux-v2.6.10 ;)

I will git-log the files in question and see if any of the bugs
are relevant here. (They should be).

Thanks that is most valuable input.
Boaz