From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753373AbYLSApu (ORCPT ); Thu, 18 Dec 2008 19:45:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752093AbYLSApl (ORCPT ); Thu, 18 Dec 2008 19:45:41 -0500 Received: from acsinet11.oracle.com ([141.146.126.233]:42926 "EHLO acsinet11.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751411AbYLSApk (ORCPT ); Thu, 18 Dec 2008 19:45:40 -0500 Message-ID: <494AEE9C.1010200@oracle.com> Date: Thu, 18 Dec 2008 16:45:16 -0800 From: Randy Dunlap Organization: Oracle Linux Engineering User-Agent: Thunderbird 2.0.0.6 (X11/20070801) MIME-Version: 1.0 To: Yinghai Lu CC: Ingo Molnar , Stephen Rothwell , linux-next@vger.kernel.org, LKML Subject: Re: linux-next: Tree for December 18 (irq.h documentation) References: <20081218230637.c879a046.sfr@canb.auug.org.au> <20081218155709.bf435d8c.randy.dunlap@oracle.com> <494AEBCA.70108@kernel.org> In-Reply-To: <494AEBCA.70108@kernel.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Source-IP: acsmt704.oracle.com [141.146.40.82] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090205.494AEE9F.00FB:SCFSTAT928724,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Yinghai Lu wrote: > Randy Dunlap wrote: >> Hi YH, >> >> Whenever you update a struct in a header file that uses kernel-doc, >> like struct irq_desc in include/linux/irq.h, please also update the >> corresponding kernel-doc notation for the new struct members, so >> that kernel-doc warnings are not caused: >> >> from linux-next-20081218: >> >> Warning(linux-next-20081218//include/linux/irq.h:192): No description found for parameter 'timer_rand_state' >> Warning(linux-next-20081218//include/linux/irq.h:192): No description found for parameter 'kstat_irqs' >> Warning(linux-next-20081218//include/linux/irq.h:192): No description found for parameter 'irq_2_iommu' >> >> > please check Thanks. Please see below. > [PATCH] sparseirq: add kernel-doc notation for new member in irq_desc > > Signed-off-by: Yinghai Lu > > diff --git a/include/linux/irq.h b/include/linux/irq.h > index 1beb63a..4675682 100644 > --- a/include/linux/irq.h > +++ b/include/linux/irq.h > @@ -135,6 +135,9 @@ struct irq_2_iommu; > /** > * struct irq_desc - interrupt descriptor > * @irq: interrupt number for this descriptor > + * @timer_rand_state pointer to timer rand state struct > + * @kstat_irqs irq stats per cpu > + * @irq_2_iommu iommu with this irq Format is: * @member: description I.e., please add a ':' after each member name. > * @handle_irq: highlevel irq-events handler [if NULL, __do_IRQ()] > * @chip: low level interrupt hardware access > * @msi_desc: MSI descriptor -- ~Randy