Re: [PATCH] coredump_filter: enable to change the default filter

Hidehiro Kawai
2008-12-19T10:05:30Z

Hi,

Roland McGrath wrote:

>>Or does the patch change other behaviour? Say, when mm_init() is
>>called by a kernel thread (current->mm==NULL)? call_usermodehelper(),
>>for example?
>>
>>If so, then setting init's filter doesn't cover that case.
>
> Hmm, probably for the kernel thread case mm_init should use
> task_active_pid_ns(current)->child_reaper->mm->flags.

It makes sense. It also enables us to change coredump_filter for
user mode helpers after the system was booted.

However, we would need a special care for PID namespace if we use
init's coredump_filter as default. For a process with new PID
namespace and new /proc, writing to /proc/1/coredump_filter doesn't
mean changing default, although it's not a usual operation.

The reason why I suggested the boot parameter way is most users
can change the default easily. Some users have difficulty to
change init scripts for various reasons.

So I think the boot parameter way is simpler for both users and
kernel developers.

Thanks,
--
Hidehiro Kawai
Hitachi, Systems Development Laboratory
Linux Technology Center