Re: [PATCH 04 of 14] swiotlb: consistently use address_needs_mapping everywhere

Ian Campbell
2008-12-17T16:45:54Z

On Wed, 2008-12-17 at 11:51 +0900, FUJITA Tomonori wrote:
> On Wed, 17 Dec 2008 11:48:41 +0900
> FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> wrote:
>
> > On Tue, 16 Dec 2008 12:17:28 -0800
> > Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> >
> > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> > > ---
> > > lib/swiotlb.c | 10 +++-------
> > > 1 file changed, 3 insertions(+), 7 deletions(-)
> >
> > This patch is wrong.
> >
> > dma_mask and coherent_dma_mask represent different restrictions.
> >
> > You can't use coherent_dma_mask for alloc_coherent.
>
> Oops, "you can't use dma_mask for alloc_coherent."

You are right, I completely overlooked that it was coherent_dma_mask in
one place and just dma_mask in the other, sorry for the noise.

Ian.