Re: [PATCH 00 of 14] swiotlb/x86: lay groundwork for xen dom0 use of swiotlb

Jeremy Fitzhardinge
2008-12-19T07:02:19Z

Becky Bruce wrote:
> I've taken a quick look at the series posted to the list, and they're
> actually very similar to what I've done. I think there are really
> only 3 fairly minor issues that need to be resolved to make this work
> on ppc:
>
> 1) We need to add swiotlb_map/unmap_page calls, as those are part the
> ppc dma_mapping_ops (in fact, we don't have map/unmap_single in the
> dma_mapping_ops struct on ppc anymore - those just call
> map/unmap_page). This is really just a matter of moving some code
> around and making some minor changes, as swiotlb_map/unmap_single can
> call swiotlb_map/unmap_page once the args have been converted.
> There's a patch in my series that should make this pretty obvious.
>
> 2) To convert any address to/from a bus address, we also need the
> hwdev pointer passed as an argument since ppc supports a per-device
> offset accessed via the device ptr that is used to calculate the bus
> address. I'd also given my conversion functions more generic names,
> as it seemed highly likely that these would eventually be useful
> outside of the swiotlb code.
>
> 3) powerpc uses enum dma_data_direction for the direction argument to
> its dma_ops, which is, from reading the kernel docs, the correct
> argument type for the DMA API functions. However, the iotlb/x86/ia64
> code is currently using an int. This causes a build warning when we
> initialize the dma_ops struct using the swiotlb funcs. Is there a
> reason for the use of "int" in x86/ia64? The Right Thing(TM) here
> seems to be to convert those over to using the enum, and I have a big
> patch that starts doing that, but I've probably missed some places. I
> could instead do some hackery on the ppc side, and leave the other
> platforms alone, but I'd prefer to do it cleanly. Thoughts?
>
> Unfortunately, this is horrible timing for me, as starting tomorrow,
> I'm going to be offline for a week and a half or so in podunk
> Louisiana with essentially no net access. I can integrate my code
> into your tree and test on PPC as soon as I return to the real world.

Yeah, I think that's OK. The important thing at this point is to
determine whether the two patch sets are aligned or conflicting. It
sounds like they're largely aligned, and so generating a delta from my
patches to match your needs will be relatively straightforward.

I'm trying to line all this Xen stuff up for this merge window, so I'd
prefer to revisit it in the next dev cycle. Did you want to get
something into this merge window?

J