Re: [PATCH 9/13] fs/xfs: Remove redundant test

Julia Lawall
2008-12-21T16:36:47Z

> Looks fine to me, though a similar test under the #ifdef DEBUG can
> probably also be removed.

Indeed. I will send an updated patch.

julia

> -Eric
>
> > ---
> > fs/xfs/xfs_trans_buf.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/fs/xfs/xfs_trans_buf.c b/fs/xfs/xfs_trans_buf.c
> > index 8ee2f8c..22afe29 100644
> > --- a/fs/xfs/xfs_trans_buf.c
> > +++ b/fs/xfs/xfs_trans_buf.c
> > @@ -307,7 +307,7 @@ xfs_trans_read_buf(
> > return (flags & XFS_BUF_TRYLOCK) ?
> > EAGAIN : XFS_ERROR(ENOMEM);
> >
> > - if ((bp != NULL) && (XFS_BUF_GETERROR(bp) != 0)) {
> > + if (XFS_BUF_GETERROR(bp) != 0) {
> > xfs_ioerror_alert("xfs_trans_read_buf", mp,
> > bp, blkno);
> > error = XFS_BUF_GETERROR(bp);
> >
> > _______________________________________________
> > xfs mailing list
> > xfs@oss.sgi.com
> > http://oss.sgi.com/mailman/listinfo/xfs
> >
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>