From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D96D36AB53 for ; Thu, 7 May 2026 15:35:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778168123; cv=none; b=ic9OANw4JFX3iXHx62HN7crH+Bgl+3FKPw6t/eF9c7gB8xzEK1CLGieujklv1dSVl1fLpsyQfyjNQAhW8hFRdzDZ3vOmFwpkAS6t2MZB0cVtJ3GmghiIVOFhySUWv0pRBXrL2EMjZQm6JmvqRECVteUOw4xNs9/fhNKESz3s3yI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778168123; c=relaxed/simple; bh=WcufHS60BkhG5Gd6zL89bvHJIT0wa5iLNW7GkfY9nBI=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=oA3gLdkWYFzBZT3xm9M6Sm5lWKzNEgNlDLP0jJDcSQXfsDHu56AIs1OdMYt2nmMAK0MnVvS+W1gV2eOInzYlC4DsQUjTqsccNDiBuOL10i2Dxs5LgAw8Bsw+SgHMSUoZZWJdS6i0IzCuvFiMR2QM1y+hcbxe5fx/KpsjupbffGw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OWenkNwJ; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OWenkNwJ" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4893940bb5eso6394555e9.3 for ; Thu, 07 May 2026 08:35:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778168120; x=1778772920; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=GI9QQt0uat60f27/e8CjUrG4GRyOGDwHMWobsR5o1QQ=; b=OWenkNwJjFPzq5G4AyNf6ANBzbbBf7clOOyMJVQH9QbWC0enmOY9FwoxXqme4SGezU uMtJ7zTonw+GAN3BY2C1RFm5UffYCYzxwvO+GPoCl8DJk4FllsAL+UFhwFDtUAb1DyzM Lr6KgYrWEC71ZC6g01obkkuyVQMLNbQ2z0rIvt4LYElpL6k8Raw5VRGbAhjkYJEkERId VBf7rC1OkrzXHwyBmUgql373bxdw8oW44c61GbM1uGqaBUEh7LrLvvrxy9T+Q7aspRVg CfyH4EmlAdDcxIOx2u0jaQIoap1oftrP57Xqp5WWXXnWQ0BEjmEDrC++PsTKamiduxJT +zRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778168120; x=1778772920; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GI9QQt0uat60f27/e8CjUrG4GRyOGDwHMWobsR5o1QQ=; b=gaDQWa6BfJg4knB0d3p9mFeYxLEti2KayaNP2oehfhyBbXE3V6gLPxWC4B1IjnO69I HujkfVSzkVWBifMY7jPhS106/Dpq0IBZu0sx0r45Sn4WgOfH1S9nQ+k6Ti7HcCnVAiZc 1gUJaOm59GQ4qX0Jcv1EQgKpDKe9Hf9IzQv7GHlhy84CHlcj0A5yjuOET/OrIhN5XOhG AwURx+UP3z4oKtJt4Q0ZI+PhFe8nDb75py9LleuLZ57ABqb3L1xzYQIeMmYF4eKxscfD GmpIcZJYD+DXKMs5meXmDn7mFWCKHrBdvu27Z7gwpfqvsbrdrxNVl6aeFNnP6iJZaJpS MukA== X-Forwarded-Encrypted: i=1; AFNElJ8kAPd1G8M6e+/hAzkJcirLDEHNeL9lk2Xu6k3dalNxwAo99txQHlupKemyXphGwyGDgpcReCh+EnmYJg8=@vger.kernel.org X-Gm-Message-State: AOJu0YyrEb4W3I/np/lBDKs1QhILVPC4t+fsFAutuadZ3GI3uvcWpMD5 a36CC2Hiom5XDXOsOy4saCSrbIOAh8Q50tbChQuqoHiArIHKQQTMoYKPfkH/d1Comts= X-Gm-Gg: AeBDiev+QmDgdStlfUrP+peDrgTtvdyHVFbOy/9EHLUJBn1zJ2dyVdFSu5wekY3CGYW 0CVwCy9XfzsiD6jk2PSNCTK9vMuCuewXfyW1EcnsPZ78kqOEMMar9E8NtdDYI9Uq/d8krxJO+JC I2cNuZWVTRUj9XOf0SKbwJSbYFIz10AW9Wasmm6J2/g+oknOSFXyod/hSgSrIcGQElBb7EloZx1 tF9wtxMnsncLofRa+/34guOaHRI4gKlmJrFletYRq9nqPoVcFPrea3qqpJSOI6iimLEEB0KpQwD o40GuyiwBhhIQ97k+oV9FvID67Ar4dr86moGMxzySi6uifRt7zcrIw+A3lbFlugMbawtCdWAr72 E2H/rOHONYgxOV1WIhDhYwAIXikSVtIRMsDGM28hFFk3yhelArbPmHvTKRCs2/n7kjKVCYChSLr dDK0dE+yrWQl09j64bB8rJhb845dhrbiM1JCa3S8QPFtmBhFRNPtLjTeeQukPUsGqsfjEG+vTdv q4A6QpkyxbsA97qKQ== X-Received: by 2002:a05:600d:18:b0:48a:75b9:5e07 with SMTP id 5b1f17b1804b1-48e51f2f14emr104673885e9.11.1778168120170; Thu, 07 May 2026 08:35:20 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:6762:47bb:1e06:ff70? ([2a01:e0a:106d:1080:6762:47bb:1e06:ff70]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e628d8da6sm12073945e9.4.2026.05.07.08.35.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 08:35:19 -0700 (PDT) Message-ID: <494a5e7d-03fe-4138-b8fb-e17110787af4@linaro.org> Date: Thu, 7 May 2026 17:35:18 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH 03/10] drm/panel/novatek-nt37700f: Use refcounted allocation in place of devm_kzalloc() To: Albert Esteve , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Michael Tretter , Michael Walle , Dario Binacchi Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260507-drm_panel_init_rm-v1-0-51f448c7c291@redhat.com> <20260507-drm_panel_init_rm-v1-3-51f448c7c291@redhat.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260507-drm_panel_init_rm-v1-3-51f448c7c291@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/7/26 13:53, Albert Esteve wrote: > Move to using the new API devm_drm_panel_alloc() to allocate the > panel. In the call to the new API, avoid using explicit type and use > __typeof() for more type safety. > > Signed-off-by: Albert Esteve > --- > drivers/gpu/drm/panel/panel-novatek-nt37700f.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-novatek-nt37700f.c b/drivers/gpu/drm/panel/panel-novatek-nt37700f.c > index 74f46a268c0f6..c221dd498fed4 100644 > --- a/drivers/gpu/drm/panel/panel-novatek-nt37700f.c > +++ b/drivers/gpu/drm/panel/panel-novatek-nt37700f.c > @@ -225,9 +225,12 @@ static int nt37700f_tianma_probe(struct mipi_dsi_device *dsi) > struct nt37700f_tianma *ctx; > int ret; > > - ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL); > - if (!ctx) > - return -ENOMEM; > + ctx = devm_drm_panel_alloc(dev, __typeof(*ctx), panel, > + &nt37700f_tianma_panel_funcs, > + DRM_MODE_CONNECTOR_DSI); > + > + if (IS_ERR(ctx)) > + return PTR_ERR(ctx); > > ctx->supply = devm_regulator_get(dev, "power"); > if (IS_ERR(ctx->supply)) > @@ -247,8 +250,6 @@ static int nt37700f_tianma_probe(struct mipi_dsi_device *dsi) > dsi->mode_flags = MIPI_DSI_MODE_VIDEO_BURST | > MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM; > > - drm_panel_init(&ctx->panel, dev, &nt37700f_tianma_panel_funcs, > - DRM_MODE_CONNECTOR_DSI); > ctx->panel.prepare_prev_first = true; > > ctx->panel.backlight = nt37700f_tianma_create_backlight(dsi); >