From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755658AbcFGP0t (ORCPT ); Tue, 7 Jun 2016 11:26:49 -0400 Received: from mail-qk0-f181.google.com ([209.85.220.181]:34117 "EHLO mail-qk0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755583AbcFGP0s (ORCPT ); Tue, 7 Jun 2016 11:26:48 -0400 From: Daniel Bristot de Oliveira X-Google-Original-From: Daniel Bristot de Oliveira Subject: Re: [PATCH] cgroup: disable irqs while holding css_set_lock To: Juri Lelli , Daniel Bristot de Oliveira References: <20160607101402.GP9340@e106622-lin> <20160607133009.GS9340@e106622-lin> Cc: linux-kernel@vger.kernel.org, Rik van Riel , "Luis Claudio R. Goncalves" , Tejun Heo , Li Zefan , Johannes Weiner , cgroups@vger.kernel.org Message-ID: <494c1f85-bbab-99f1-4095-914aaebdd708@redhat.com> Date: Tue, 7 Jun 2016 12:26:42 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20160607133009.GS9340@e106622-lin> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ciao Juri, On 06/07/2016 10:30 AM, Juri Lelli wrote: > So, this and the partitioned one could actually overlap, since we don't > set cpu_exclusive. Is that right? > > I guess affinity mask of both m processes gets set correclty, but I'm > not sure if we are missing one check in the admission control. Can you > actually create two overlapping sets and get DEADLINE tasks running in > them? For example, what happens if partitioned is [4] and clustered is > [4-7]? Does setattr() fail? That is what I was trying to understand/break. Fortunately, I still can't break it! bravo! :-) In the test you mentioned the task in the "clustered" fails to sched_setattr(). Test output example: + '[' '!' -d partitioned ']' + mkdir partitioned + echo 4 + echo 0 + echo 0 + echo 1155 + cat /proc/self/cpuset /partitioned + /root/m main thread [1162] deadline thread started [1164] + '[' '!' -d clustered ']' + mkdir clustered + echo 4-7 + echo 0 + echo 0 + echo 1 + echo 1155 + cat /proc/self/cpuset + /root/m /clustered + /root/m main thread [1166] sched_setattr: Operation not permitted I will let you know if I find something odd. -- Daniel