From: Mike Travis <travis@sgi.com>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: mingo@elte.hu, hpa@zytor.com, tglx@linutronix.de,
rusty@rustcorp.com.au, linux-kernel@vger.kernel.org
Subject: Re: [patch] x86: use logical apicid in x2apic_cluster's x2apic_cpu_mask_to_apicid_and()
Date: Mon, 22 Dec 2008 17:46:26 -0800 [thread overview]
Message-ID: <495042F2.5080503@sgi.com> (raw)
In-Reply-To: <20081223013327.GA29686@linux-os.sc.intel.com>
Suresh Siddha wrote:
> From: Suresh Siddha <suresh.b.siddha@intel.com>
> Subject: x86: use logical apicid in x2apic_cluster's x2apic_cpu_mask_to_apicid_and()
>
> These commits:
>
> commit 95d313cf1c1ecedc8bec5727b09bdacbf67dfc45
> Author: Mike Travis <travis@sgi.com>
> Date: Tue Dec 16 17:33:54 2008 -0800
>
> x86: Add cpu_mask_to_apicid_and
>
> and
> commit 6eeb7c5a99434596c5953a95baa17d2f085664e3
> Author: Mike Travis <travis@sgi.com>
> Date: Tue Dec 16 17:33:55 2008 -0800
>
> x86: update add-cpu_mask_to_apicid_and to use struct cpumask*
>
> broke interrupt delivery on x2apic platforms. As x2apic cluster mode uses
> logical delivery mode, we need to use logical apicid instead of physical apicid
> in x2apic_cpu_mask_to_apicid_and()
>
> Impact: fixes the broken interrupt delivery issue on generic x2apic platforms.
>
> Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
Thanks Suresh for catching this! You can add my
Acked-by: Mike Travis <travis@sgi.com>
> ---
>
> Index: tip/arch/x86/kernel/genx2apic_cluster.c
> ===================================================================
> --- tip.orig/arch/x86/kernel/genx2apic_cluster.c 2008-12-22 17:15:38.000000000 -0800
> +++ tip/arch/x86/kernel/genx2apic_cluster.c 2008-12-22 17:16:17.000000000 -0800
> @@ -114,7 +114,7 @@
> int cpu;
>
> /*
> - * We're using fixed IRQ delivery, can only return one phys APIC ID.
> + * We're using fixed IRQ delivery, can only return one logical APIC ID.
> * May as well be the first.
> */
> cpu = cpumask_first(cpumask);
> @@ -130,14 +130,14 @@
> int cpu;
>
> /*
> - * We're using fixed IRQ delivery, can only return one phys APIC ID.
> + * We're using fixed IRQ delivery, can only return one logical APIC ID.
> * May as well be the first.
> */
> for_each_cpu_and(cpu, cpumask, andmask)
> if (cpumask_test_cpu(cpu, cpu_online_mask))
> break;
> if (cpu < nr_cpu_ids)
> - return per_cpu(x86_cpu_to_apicid, cpu);
> + return per_cpu(x86_cpu_to_logical_apicid, cpu);
> return BAD_APICID;
> }
>
next prev parent reply other threads:[~2008-12-23 1:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-23 1:33 [patch] x86: use logical apicid in x2apic_cluster's x2apic_cpu_mask_to_apicid_and() Suresh Siddha
2008-12-23 1:46 ` Mike Travis [this message]
2008-12-23 2:05 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=495042F2.5080503@sgi.com \
--to=travis@sgi.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox