From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Michael Estner <michaelestner@web.de>
Cc: michaelestner@web.de, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Remove uneccessary parantheas
Date: Sun, 26 Sep 2021 10:13:46 +0200 [thread overview]
Message-ID: <4951952.txS7XvjiL2@localhost.localdomain> (raw)
In-Reply-To: <20210925192018.6745-1-michaelestner@web.de>
On Saturday, September 25, 2021 9:20:15 PM CEST Michael Estner wrote:
> Fix to be conform with the checkpatch style requirements
Greg K-H's "friendly patch bot" has already been triggered and sent you a
message. Usually, according to Greg's style :), this is all you get and then
you are left alone to figure out what you did wrong and eventually submit a
new version.
However, as this is your very first patch, I would like to give you some
additional information that may help you.
1) Where is the name of the driver your fixing? You must place it in the
subject and its position and formatting must comply with this subsystem
rules. Please, read other patches for staging among those that have already
been accepted.
2) What language are you using in the subject? "Remove uneccessary
parantheas" has no meaning in English. Typos can happen, but you have not
made any typos: your "Subject line" is a completely incomprehensible sequence
of characters. :)
3) "Fix to be conform[]" (sigh). Fix what? Changelogs (or "Commits messages")
must be self-contained, so write them like if you expected that the Reviewers
immediately forget what they read in the "Subject" line. While you are at it,
please also correct grammar.
(Finally, it is the Linux kernel maintainers and developers who have "style
requirements", listed in the "Linux kernel coding style" document, instead
checkpatch.pl has no requirements (it just checks for style violations)).
Thanks,
Fabio
> Signed-off-by: Michael Estner <michaelestner@web.de>
> ---
prev parent reply other threads:[~2021-09-26 8:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-25 19:20 [PATCH] Remove uneccessary parantheas Michael Estner
2021-09-26 6:52 ` Greg Kroah-Hartman
2021-09-26 8:13 ` Fabio M. De Francesco [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4951952.txS7XvjiL2@localhost.localdomain \
--to=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=michaelestner@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox