Re: [PATCH] ftrace: enable format arguments checking

[Lai Jiangshan <laijs@cn.fujitsu.com>]

Lai Jiangshan wrote:
> format arguments checking for ftrace_printk() is __printf(1, 2),
> not __printf(1, 0).
> 
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> ---
> diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h
> index 9c5bc6b..0c71788 100644
> --- a/include/linux/ftrace.h
> +++ b/include/linux/ftrace.h
> @@ -210,7 +210,7 @@ extern void ftrace_dump(void);
>  static inline void
>  ftrace_special(unsigned long arg1, unsigned long arg2, unsigned long arg3) { }
>  static inline int
> -ftrace_printk(const char *fmt, ...) __attribute__ ((format (printf, 1, 0)));

Hi, Steven Rostedt
	Did you notice this patch?
	This patch changed a char in a line: s/0/2/. It enables the format checking.

	Lai.

> +ftrace_printk(const char *fmt, ...) __attribute__ ((format (printf, 1, 2)));
>  
>  static inline int
>  ftrace_printk(const char *fmt, ...)
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
> 
>