From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752600AbYLXDt6 (ORCPT ); Tue, 23 Dec 2008 22:49:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751392AbYLXDtt (ORCPT ); Tue, 23 Dec 2008 22:49:49 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:55309 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751254AbYLXDtt (ORCPT ); Tue, 23 Dec 2008 22:49:49 -0500 Message-ID: <4951B09A.4070803@cn.fujitsu.com> Date: Wed, 24 Dec 2008 11:46:34 +0800 From: Lai Jiangshan User-Agent: Thunderbird 2.0.0.18 (Windows/20081105) MIME-Version: 1.0 To: Steven Rostedt CC: Ingo Molnar , Linux Kernel Mailing List Subject: Re: [PATCH] ftrace: enable format arguments checking References: <494CB7A2.1070603@cn.fujitsu.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Steven Rostedt wrote: > On Sat, 20 Dec 2008, Lai Jiangshan wrote: > > Could you resubmit with a "Impact" line. > > Thanks, > Impact: check format for ftrace_printk() when CONFIG_TRACING=n format arguments checking for ftrace_printk() is __printf(1, 2), not __printf(1, 0). Signed-off-by: Lai Jiangshan --- diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h index 9c5bc6b..0c71788 100644 --- a/include/linux/ftrace.h +++ b/include/linux/ftrace.h @@ -210,7 +210,7 @@ extern void ftrace_dump(void); static inline void ftrace_special(unsigned long arg1, unsigned long arg2, unsigned long arg3) { } static inline int -ftrace_printk(const char *fmt, ...) __attribute__ ((format (printf, 1, 0))); +ftrace_printk(const char *fmt, ...) __attribute__ ((format (printf, 1, 2))); static inline int ftrace_printk(const char *fmt, ...)