* [PATCH] x86: remove impossible test in mtrr/main.c
@ 2008-12-25 6:48 Rusty Russell
2008-12-25 20:47 ` H. Peter Anvin
0 siblings, 1 reply; 3+ messages in thread
From: Rusty Russell @ 2008-12-25 6:48 UTC (permalink / raw)
To: Ingo Molnar; +Cc: linux-kernel, Yinghai Lu
Impact: cleanup
enable_mtrr_cleanup is static, and is never set to anything but 0 or 1.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
diff --git a/arch/x86/kernel/cpu/mtrr/main.c b/arch/x86/kernel/cpu/mtrr/main.c
--- a/arch/x86/kernel/cpu/mtrr/main.c
+++ b/arch/x86/kernel/cpu/mtrr/main.c
@@ -823,16 +823,14 @@ static int enable_mtrr_cleanup __initdat
static int __init disable_mtrr_cleanup_setup(char *str)
{
- if (enable_mtrr_cleanup != -1)
- enable_mtrr_cleanup = 0;
+ enable_mtrr_cleanup = 0;
return 0;
}
early_param("disable_mtrr_cleanup", disable_mtrr_cleanup_setup);
static int __init enable_mtrr_cleanup_setup(char *str)
{
- if (enable_mtrr_cleanup != -1)
- enable_mtrr_cleanup = 1;
+ enable_mtrr_cleanup = 1;
return 0;
}
early_param("enable_mtrr_cleanup", enable_mtrr_cleanup_setup);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: remove impossible test in mtrr/main.c
2008-12-25 6:48 [PATCH] x86: remove impossible test in mtrr/main.c Rusty Russell
@ 2008-12-25 20:47 ` H. Peter Anvin
2008-12-25 21:14 ` H. Peter Anvin
0 siblings, 1 reply; 3+ messages in thread
From: H. Peter Anvin @ 2008-12-25 20:47 UTC (permalink / raw)
To: Rusty Russell; +Cc: Ingo Molnar, linux-kernel, Yinghai Lu
Rusty Russell wrote:
> Impact: cleanup
>
> enable_mtrr_cleanup is static, and is never set to anything but 0 or 1.
>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Applied to tip:x86/pat2, thanks!
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: remove impossible test in mtrr/main.c
2008-12-25 20:47 ` H. Peter Anvin
@ 2008-12-25 21:14 ` H. Peter Anvin
0 siblings, 0 replies; 3+ messages in thread
From: H. Peter Anvin @ 2008-12-25 21:14 UTC (permalink / raw)
To: Rusty Russell; +Cc: Ingo Molnar, linux-kernel, Yinghai Lu
H. Peter Anvin wrote:
> Rusty Russell wrote:
>> Impact: cleanup
>>
>> enable_mtrr_cleanup is static, and is never set to anything but 0 or 1.
>>
>> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>
> Applied to tip:x86/pat2, thanks!
>
I meant tip:x86/cleanups, of course.
-hpa
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-12-25 21:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-25 6:48 [PATCH] x86: remove impossible test in mtrr/main.c Rusty Russell
2008-12-25 20:47 ` H. Peter Anvin
2008-12-25 21:14 ` H. Peter Anvin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox