From: Rik van Riel <riel@redhat.com>
To: Udo van den Heuvel <udovdh@xs4all.nl>
Cc: linux-kernel@vger.kernel.org
Subject: Re: BUG or virtualbox issue?
Date: Fri, 26 Dec 2008 14:42:03 -0500 [thread overview]
Message-ID: <4955338B.2010804@redhat.com> (raw)
In-Reply-To: <4954C095.3080300@xs4all.nl>
Udo van den Heuvel wrote:
> Hello,
>
> Just started virtualbox for the first time on x86_64 Phenom system; is
> this a kernel issue or something for the VirtualBox people?
>
> Dec 26 12:20:01 surfplank2 kernel: BUG: using smp_processor_id() in
> preemptible [00000000] code: VirtualBox/26774
> Dec 26 12:20:01 surfplank2 kernel: caller is RTMpCpuId+0x9/0x10 [vboxdrv]
> Dec 26 12:20:01 surfplank2 kernel: Pid: 26774, comm: VirtualBox Not
> tainted 2.6.28 #3
Looks like the virtualbox code forgot to switch off
preemption before calling smp_processor_id().
This is broken, because the thread could get de-scheduled
and re-scheduled onto another CPU, which means the code
could end up using the wrong smp processor ID.
--
All rights reversed.
prev parent reply other threads:[~2008-12-26 19:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-26 11:31 BUG or virtualbox issue? Udo van den Heuvel
2008-12-26 19:42 ` Rik van Riel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4955338B.2010804@redhat.com \
--to=riel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=udovdh@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox