PATCH - ksymoops on Alpha - 2.4.5-ac3

PATCH - ksymoops on Alpha - 2.4.5-ac3

[George France]

[-- Attachment #1: Type: text/plain, Size: 632 bytes --]

Here is a trivial patch that will make ksymoops work again on Alpha.

--George

diff -urN linux-2.4.5-ac3-orig/arch/alpha/kernel/traps.c 
linux/arch/alpha/kernel/traps.c
--- linux-2.4.5-ac3-orig/arch/alpha/kernel/traps.c	Thu May 24 17:24:37 2001
+++ linux/arch/alpha/kernel/traps.c	Mon May 28 16:38:25 2001
@@ -286,11 +286,7 @@
 			continue;
 		if (tmp >= (unsigned long) &_etext)
 			continue;
-		/*
-		 * Assume that only the low 24-bits of a kernel text address
-		 * is interesting.
-		 */
-		printk("%6x%c", (int)tmp & 0xffffff, (++i % 11) ? ' ' : '\n');
+		printk("%16lx%c", tmp);
 #if 0
 		if (i > 40) {
 			printk(" ...");


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch-ksymoops-alpha --]
[-- Type: text/english; name="patch-ksymoops-alpha", Size: 550 bytes --]

diff -urN linux-2.4.5-ac3-orig/arch/alpha/kernel/traps.c linux/arch/alpha/kernel/traps.c
--- linux-2.4.5-ac3-orig/arch/alpha/kernel/traps.c	Thu May 24 17:24:37 2001
+++ linux/arch/alpha/kernel/traps.c	Mon May 28 16:38:25 2001
@@ -286,11 +286,7 @@
 			continue;
 		if (tmp >= (unsigned long) &_etext)
 			continue;
-		/*
-		 * Assume that only the low 24-bits of a kernel text address
-		 * is interesting.
-		 */
-		printk("%6x%c", (int)tmp & 0xffffff, (++i % 11) ? ' ' : '\n');
+		printk("%16lx%c", tmp);
 #if 0
 		if (i > 40) {
 			printk(" ...");

Re: PATCH - ksymoops on Alpha - 2.4.5-ac3

[Keith Owens]

On Mon, 28 May 2001 17:05:45 -0400, 
George France <france@handhelds.org> wrote:
>Here is a trivial patch that will make ksymoops work again on Alpha.

Thanks for that.  Now if you can just persuade the Alpha people to
print the 'Code:' line in the same format as other architectures then
ksymoops can decode the instructions as well.  If Alpha wants to
include its own instruction decoder as well then that is up to them but
I would appreciate a standard 'Code:' line being printed first.

Re: PATCH - ksymoops on Alpha - 2.4.5-ac3

[George France]

[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]

> George France <france@handhelds.org> wrote:
> >Here is a trivial patch that will make ksymoops work again on Alpha.

Cleaner patch.

diff -urN linux-2.4.5-ac3-orig/arch/alpha/kernel/traps.c 
linux-2.4.5/arch/alpha/kernel/traps.c
--- linux-2.4.5-ac3-orig/arch/alpha/kernel/traps.c	Thu May 24 17:24:37 2001
+++ linux-2.4.5/arch/alpha/kernel/traps.c	Tue May 29 00:42:40 2001
@@ -286,17 +286,11 @@
 			continue;
 		if (tmp >= (unsigned long) &_etext)
 			continue;
-		/*
-		 * Assume that only the low 24-bits of a kernel text address
-		 * is interesting.
-		 */
-		printk("%6x%c", (int)tmp & 0xffffff, (++i % 11) ? ' ' : '\n');
-#if 0
+		printk("%lx%c", tmp, ' ');
 		if (i > 40) {
 			printk(" ...");
 			break;
 		}
-#endif
 	}
 	printk("\n");
 }


>
> Thanks for that.  Now if you can just persuade the Alpha people to
> print the 'Code:' line in the same format as other architectures then
> ksymoops can decode the instructions as well.  If Alpha wants to
> include its own instruction decoder as well then that is up to them but
> I would appreciate a standard 'Code:' line being printed first.

Could you send me an oops with the standard 'Code:' line? 

Best Regards,


--George

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch-ksymoops --]
[-- Type: text/english; name="patch-ksymoops", Size: 613 bytes --]

diff -urN linux-2.4.5-ac3-orig/arch/alpha/kernel/traps.c linux-2.4.5/arch/alpha/kernel/traps.c
--- linux-2.4.5-ac3-orig/arch/alpha/kernel/traps.c	Thu May 24 17:24:37 2001
+++ linux-2.4.5/arch/alpha/kernel/traps.c	Tue May 29 00:42:40 2001
@@ -286,17 +286,11 @@
 			continue;
 		if (tmp >= (unsigned long) &_etext)
 			continue;
-		/*
-		 * Assume that only the low 24-bits of a kernel text address
-		 * is interesting.
-		 */
-		printk("%6x%c", (int)tmp & 0xffffff, (++i % 11) ? ' ' : '\n');
-#if 0
+		printk("%lx%c", tmp, ' ');
 		if (i > 40) {
 			printk(" ...");
 			break;
 		}
-#endif
 	}
 	printk("\n");
 }

Re: PATCH - ksymoops on Alpha - 2.4.5-ac3

[Keith Owens]

On Tue, 29 May 2001 01:00:56 -0400, 
George France <france@handhelds.org> wrote:
>Could you send me an oops with the standard 'Code:' line? 

arch/mips/kernel/traps.c show_code() is a good example.  It prints

Code: xxxxxxxx xxxxxxxx xxxxxxxx <xxxxxxxx> xxxxxxxx xxxxxxxx

So it prints a few words either side of the failing instruction and
marks the failure by '<>'.